Only one thing comes in my mind regarding the broken previews. Could it be that the "distributeOptions" should change after the merging i've made?

https://github.com/chrispetsos/prefsEditors/blob/master/src/shared/adjusters/js/ContrastAdjuster.js#L116-L125
https://github.com/chrispetsos/prefsEditors/blob/master/src/shared/adjusters/js/CursorSizeAdjuster.js#L48-L59
https://github.com/chrispetsos/prefsEditors/blob/master/src/shared/adjusters/js/MagnifierAdjuster.js#L204-L208
https://github.com/chrispetsos/prefsEditors/blob/master/src/shared/adjusters/js/TextSizeAdjuster.js#L191-L199

From: chrispetsos@msn.com
To: reply@reply.github.com
CC: obara.justin@gmail.com
Subject: RE: [prefsEditors] GPII-187, GPII-188, GPII-225, GPII-227 contributions (#7)
Date: Fri, 25 Oct 2013 16:40:39 +0300




Indeed very strange, yes i've committed everything, could it be a browser issue? I've tried with Firefox and Chrome and it works OK... Do you get any console exceptions?
Well, i've replaced refreshView for two reasons:
1) It broke the preview functionality after its first invocation until page reloaded. So, mainly it totally broke the preview functionality.
2) Since {that} is now the big increaseSize component, it repainted the whole adjuster group making the overall experience laggy and the preview windows flashing because they were re-rendered. I didn't like it...
I know this is not very elegant but i'm trying to get the adjusters as close as possible to the state prior to performing the merging...
Can't think of something clever on the "breakage between the preview and the model". Is this perhaps related to the bug we have with the previews stop working on Save/Cancel/Reset? Could the Infusion lib update i'm expecting solve this?


Date: Fri, 25 Oct 2013 06:21:33 -0700
From: notifications@github.com
To: prefsEditors@noreply.github.com
CC: chrispetsos@msn.com
Subject: Re: [prefsEditors] GPII-187, GPII-188, GPII-225, GPII-227 contributions (#7)

In src/pmt/js/PMT.js:

> +                },
> +                resetButtonText: {
> +                    expander: {
> +                        func: "gpii.uiOptions.pmt.lookupMsg",
> +                        args: ["{uiOptionsLoader}.msgBundle", "resetButtonText"]
> +                    }
> +                },
> +                cancelButtonText: {
> +                    expander: {
> +                        func: "gpii.uiOptions.pmt.lookupMsg",
> +                        args: ["{uiOptionsLoader}.msgBundle", "cancelButtonText"]
> +                    }
> +                }
> +            },
> +            components: {
> +                increaseSizeExtraAdjustersComponent: {

Hmm.. those things still aren't working for me. Did you commit everything? At any rate, I'd suggest against reimplmenting or replacing refreshView if possible. And I'm not quite sure I understand why you have tried to do that as a work around here. Some more details might be helpful. 


Also I have to say I made a mistake when reading the code before. I mistook the preview for the slider. So the slider is in the prototree and should be refreshed every time you rerender. The problem from what I can see now is that there is some breakage between the preview and the model. The model is being updated correctly, but the preview isn't displaying those changes until it is refreshed. 


—
Reply to this email directly or view it on GitHub.