We agreed on PEP8, but it does not require to break lines.
My opinion, I would not  use any automatic breaking lines.

For me, 160 is minimum.


Best regards,
Filip Jurcicek

-------------------------------------------------------
Work tel. (CZ): +420221914402
Personal tel. (CZ): +420777805048
Skype: bozskyfilip

http://ufal.mff.cuni.cz/staff.html
http://sites.google.com/site/filipjurcicek/


On 22 October 2013 14:35, Ondrej Dusek <notifications@github.com> wrote:

> In alex/applications/PublicTransportInfoCS/hdc_policy.py:
>
> >          """
> >          route = dialogue_state.directions.routes[dialogue_state['route_alternative']]
> >          leg = route.legs[0]
> >          da = DialogueAct()
> >          for step in leg.steps:
> >              if step.travel_mode == step.MODE_TRANSIT:
> > -                da.append(DialogueActItem('inform', 'from_stop', step.departure_stop))
> > +                da.append(DialogueActItem('inform', 'from_stop',
>
> The line length of max. 80 chars is a part of PEP8 style on which we
> agreed... I thought that I am required to break the lines that way (and
> PyDev in Eclipse complains if I don't do so). I do not like it myself... I
> also think 80 is too short.
>
> So you suggest we should set the limit higher (or have no limit at all)?
> If you're suggesting a limit of 180, I would say it's too much. I think
> 100-128 is the reasonable range.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/UFAL-DSG/alex/pull/7/files#r7123763>
> .
>