started adding rspec tests