That is the code which I wondered how my tests didn't discover the xblock
problem, though. Since split isn't used in production yet, but others are
helping to move it quickly in that direction, there's no risk in merging
this and this code already exists in master anyway.


On Fri, Aug 16, 2013 at 9:21 AM, Don-edX Mitchell <dmitchell@edx.org> wrote:

> No. 67 unearths a bug, but it's my current work on refactoring
> editable_metadata which is particularly impinged. Also, I'm gone from Tues
> until the following Wednesday and dread bit rot.
>
>
> On Fri, Aug 16, 2013 at 9:18 AM, Calen Pennington <
> notifications@github.com> wrote:
>
>> In common/lib/xmodule/xmodule/modulestore/split_mongo/split_mongo_kvs.py:
>>
>> >          elif key.scope == Scope.settings:
>> > -            if key.field_name in self._metadata:
>> > -                return self._metadata[key.field_name]
>> > -            elif key.field_name in self._inherited_metadata:
>> > -                return self._inherited_metadata[key.field_name]
>> > +            # didn't find in _fields; so, get from inheritance since not locally set
>> > +            if key.field_name in self._inherited_settings:
>> > +                return self._inherited_settings[key.field_name]
>>
>> We should wait on merging this until edx/XBlock#67<https://github.com/edx/XBlock/issues/67>is merged, right?
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/edx/edx-platform/pull/624/files#r5813396>
>> .
>>
>
>