El Jueves, 4 de abril de 2013 12:30:20 Nathan Dimmock escribió:
> > +    return $cmd->{NoAction} || $out;
> I think you need to define what this method can return in the docs.

You are right.  I'm typing something better now.

> I assume $cmd->{NoAction} returns a 0 or 1 (or maybe undef/1 ?),

NoAction is a boolean.  Depending on Perl's taste, it's typically
undef/1.  The method returns a defined value upon success and undef upon
errors.  And not executing the command is not an error.

> By extension of this, I wonder if the comment based documentation at
> the top of this method should be replaced with POD instead?

Fine.

I'll post the patch in a few minutes.  Thanks for the review and the
feedback.
--
Luis Fernando Muñoz Mejías
lfmunozmejias@gmail.com