Initialise m_filesize in the radio stream ctor of MusicMetadata

Fixes Coverity 1023898 Uninitialized scalar field
Check albumart_image is not NULL in MusicMetadata::getAlbumArtFile()

Fixes Coverity ID 1023882 Dereference after null check.

This would appear to be false positive in that if res is not empty then
albumart_image cannot be NULL anyway.
Fix what looks like a copy/paste error in MetaIO::readFromFilename()

Fixes Coverity ID 1023881 Copy-paste error.
Initialise all the pointers in GetNvidiaRates()'s buf[256] to NULL. Coverity 746855
Fix for duplicate (dead) assignment in util-nvctl.cpp

Static analysis (scan-build) identified a dead assignment
in util-nvctl.cpp, where h was assigned a value, and
assigned (the same) value three lines later.  Delete
the duplicate assignment.
(cherry picked from commit 7a2a48df924debd2ec42246e2c218d289ba60241)

Signed-off-by: Stuart Morgan <smorgan@mythtv.org>
Revert "Initialise all the pointers in GetNvidiaRates()'s buf[256] to
NULL. Coverity 746855"

This is causing a segfault at frontend startup for me, switching it to
use memset() instead causes the same problem. I suspect that 256 is
far larger than it needs to be but I'm not sure whether that's causing
us to run out of memory?

This reverts commit f1d33c50ed09ac1b151a0bac1c5b09b386501313.
MythMusic: append "\r\n" to the Authorization line in the shoutcast header

This fixes a problem with connecting to ice/shoutcast streams requiring
authentication.

Thanks to dashs on irc for finding the error.
MythMusic: remove any username/password when displaying any radio stream URLs
rework FindUnusedPID after heads up from Coverty

Avoid the special purpose Null PID while here.
Its still not perfect, but should be good enough for its intended use
when recording radio.
fix Failed CRC check 0xVARIABLE != 0xVARIABLE for StreamID = 0x80-0x8f

PSIPTable::HasCRC defaults everything 0x80-0xfe to true due to Dishnet.
But the real CA_message_section doesn't have a CRC.

This should fix ECM/EMM spamming the logs with false errors.
Avoid a compiler static analysis warning.

Move a variable declaration/initialization into the only scope where
it is actually used.

Signed-off-by: Jim Stichnoth <jstichnoth@mythtv.org>
MythMusic: remove some redundant code from CdDecoder
Potentially fix segfaults on frontend startup

In nvctrl-util's GetNvidiaRates():
Initialise buf values to NULL, reduce it's size from 256 to 8 since
we're only interested in the first 8 tokens and actually check that we
parsed all 8 from the string before proceeding to use them.

While here change logging from VB_PLAYBACK to VB_GUI which makes more sense.

This may fix some frontend startup segfaults experienced by some
people since we ended up using an area of uninitialised memory in
strtol.

Coverity 746855
Add a constructor to ArbitraryLocatedData to initialise members

Coverity 746854
Pull in fix for out-of-bounds array write in xine_demux_sputext.cpp from upstream. Coverity 746831
Fix fence post error in 516719a
Add a few flag tests to MythSystem.
Add MythSystem unit test for kMSAnonLog
Have make test in basedir rebuild test code if necessary.
Have make in basedir run unit tests on all target.

Note: An all_no_test target has been added to bypass unit tests when iterating on code.