final v1.0 need test cases