committing modal and changes