fixed.


On Mon, Apr 8, 2013 at 12:39 AM, P. Oscar Boykin
<notifications@github.com>wrote:

> In
> scalding-core/src/main/scala/com/twitter/scalding/mathematics/Matrix.scala:
>
> > @@ -573,6 +626,40 @@ class Matrix[RowT, ColT, ValT]
> >      new Matrix[RowT,ColT,(ValT,ValU)](rowSym, colSym, valSym, zipped, sizeHint + that.sizeHint)
> >    }
> >
> > +  /**
> > +   * removes any elements in this matrix that also appear in the argument matrix
> > +   */
> > +  def filterBy[ValU](that : Matrix[RowT,ColT,ValU]) : Matrix[RowT,ColT,ValT] = {
>
> I'm worried that in scala, filter takes a predicate that means *keep* the
> items (and there is filterNot for the opposite). It seem like this method
> is somewhat the reverse semantics, if the predicate here is: that is
> defined at (row, col), then this is a filterNot.
>
> Can we be more verbose here? removeElementsBy? Then we could also have
> keepElementsBy and keep with your keepBy semantics below.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/twitter/scalding/pull/365/files#r3688741>
> .
>