Remove ineffective -Wunused-parameter for test code

This has no effect, as it is overridden by the use of -Wno-unused-parameter in
build/common.gypi. There are numerous cases where code built by these targets
does not comply with this warning.

R=abarth@chromium.org, abarth

Review URL: https://codereview.chromium.org/64743003

git-svn-id: svn://svn.chromium.org/blink/trunk@161582 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Deflake svg/as-object/nested-embedded-svg-size-changes.html

r161493 changed how finishJSTest behaves which made
nested-embedded-svg-size-changes.html flaky due to load timing.
This patch deflakes the test by moving jsTestIsAsync to the top of
the script block so it executes first.

BUG=316460
TBR=ojan,kbr
NOTRY=true

Review URL: https://codereview.chromium.org/65533007

git-svn-id: svn://svn.chromium.org/blink/trunk@161583 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Update TestExpectations after r161583

r161583 removed some lines it should not have from TestExpectations.
This patch adds them back.

BUG=316460
TBR=kbr
NOTRY=true

Review URL: https://codereview.chromium.org/61793005

git-svn-id: svn://svn.chromium.org/blink/trunk@161584 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Fix mixed end-of-line code in windowless_plugin_paint_test.html.

It contains LF-lines and CRLF-lines. This CL removes CR characters.

BUG=noen
TBR=keishi@chromium.org

Review URL: https://codereview.chromium.org/66243002

git-svn-id: svn://svn.chromium.org/blink/trunk@161585 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Auto-rebaseline for r161583

http://src.chromium.org/viewvc/blink?view=revision&revision=161583

BUG=316460
TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/66283002

git-svn-id: svn://svn.chromium.org/blink/trunk@161586 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Prepare for deprecating DatabaseObserver.{h,cpp}

For fixing layering violation (declared in WebCore, implemented in Source/web)

1. Add DatabaseClient for canEstablishDatabase()
2. Add WebPlatformDatabaseObserver in platform layer for remaining methods

BUG=none
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/64353002

git-svn-id: svn://svn.chromium.org/blink/trunk@161587 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Suppress a flaky layout test.

NOTRY=true
BUG=316372
TBR=antonm@chromium.org, kbr@chromium.org

Review URL: https://codereview.chromium.org/61763018

git-svn-id: svn://svn.chromium.org/blink/trunk@161588 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Ctr+F search in Profiles panel should search only in the selected profile

This CL removes the code that supported search through all profiles in the Profiles panel. In the offline discussion we unanimously agreed that the search should apply to the selected profile only.

This change also removes bubble from SidebarTreeElement. The bubble was used to show search matches count in the corresponding profile only. It allowed to also remove searchSmall*.png icons and CSS styles that referenced them.

BUG=316104
R=vsevik@chromium.org

Review URL: https://codereview.chromium.org/66343002

git-svn-id: svn://svn.chromium.org/blink/trunk@161592 bbb929c8-8fbe-4397-9dbb-9b2b20218538
DevTools: [Elements] Restore scrollTop after hidden DOM tree updates

R=pfeldman@chromium.org, pfeldman, vsevik
BUG=316215

Review URL: https://codereview.chromium.org/66423002

git-svn-id: svn://svn.chromium.org/blink/trunk@161593 bbb929c8-8fbe-4397-9dbb-9b2b20218538
IDL compiler: [StrictTypeChecking] methods

BUG=239771
NOTRY=true

Review URL: https://codereview.chromium.org/58923005

git-svn-id: svn://svn.chromium.org/blink/trunk@161594 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Update the accessibility tree when a modal dialog is opened/closed.

When a node's inertness changes, we must notify the AX tree since
the node may need to be added or removed from the tree.

This patch does the following.
1) When an modal dialog opens/closes, essentially we traverse the AX
tree and call notifyIfIgnoredValueChanged on each object. However, once
an object is found whose ignored value changed, it's not necessary to
descend into its subtree by virtue of the childrenCleared/addChild
mechanism.

An earlier attempt called notifyIfIgnoredValueChanged only on immediate
children of the HTMLBodyElement. This is insufficient because siblings
of <dialog> are roots of newly (or formerly) inert subtrees, and some
objects are not descendants of body due to renderer reparenting (e.g.
modal dialogs).

2) Modifies AXObject::isInertOrAriaHidden to climb the AX tree until an
object with non-null node() is found, when evaluating inertness. This is
necessary because some objects such as one created with
MenuListPopupRole don't have a node, but should be considered inert.

The test for this patch is Chrome-side:
https://codereview.chromium.org/64273003

BUG=304779

Review URL: https://codereview.chromium.org/59663005

git-svn-id: svn://svn.chromium.org/blink/trunk@161595 bbb929c8-8fbe-4397-9dbb-9b2b20218538
ComposedTreeWalker does't have to return a node if an insertion point has no distributed nodes.

A content insertion point never has child nodes if the insertion point has distributed nodes after r161137.

A shadow insertion point may have child nodes even if the insertion point has
no distributed nodes.  We should return 0 in this case because child nodes of the
shadow insertion point must not be treated as fallback elements after r161137.

The relevant spec is:
https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#distributions

BUG=None

Review URL: https://codereview.chromium.org/60203009

git-svn-id: svn://svn.chromium.org/blink/trunk@161596 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Remove unnecessary step() calls from readystatechange-and-abort.html

BUG=none

Review URL: https://codereview.chromium.org/61753006

git-svn-id: svn://svn.chromium.org/blink/trunk@161597 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Make "InsertHTML" and "Indent" commands to handle DOM tree modification during processing

This patch makes "InsertHTML" and "Indent" commands to handle DOM tree modification during processing. When calling Node::insertBefore(), JavaScript may be executed, e.g. <iframe src="javascript:...">, and it modifies DOM tree.

On issue 314469, use-after-free is caused at |startBlock| variable which holds raw Node pointer removed during script execution in ReplaceSelectionCommand::doApply().

Changes for CompositeEditCommand::cloneParagraphUnderNewElement() is similar to ReplaceSelectionCommand::doApply(). |outerNode| is removed during CompositeEditCommand::appendNode(), which inserts <iframe src="javascript:...">.

BUG=314469
TEST=LayoutTests/editing/inserting/insert-with-javascript-protocol-crash.html

Review URL: https://codereview.chromium.org/64103002

git-svn-id: svn://svn.chromium.org/blink/trunk@161598 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Cleanup DateMath.{cpp,h}.

Remove the following unused variables and functions:
- maxECMAScriptTime
- msPerMonth
- parseES5DatePortion()
- parseES5TimePortion()
- parseES5DateFromNullTerminatedCharacters()
- timeClip()

Unexpose the following variables and functions:
- hoursPerDay
- secondsPerHour
- equivalentYearForDST()
- parseDateFromNullTerminatedCharacters(const char*, bool&, int&)
- jsCurrentTime()
- msToDays()
- msToMinutes()
- msToHours()

BUG=

Review URL: https://codereview.chromium.org/60013012

git-svn-id: svn://svn.chromium.org/blink/trunk@161599 bbb929c8-8fbe-4397-9dbb-9b2b20218538
IDL compiler: [TreatReturnedNullStringAs] methods

V. simple change b/c already implemented in type handling.

BUG=239771
NOTRY=true

Review URL: https://codereview.chromium.org/60753003

git-svn-id: svn://svn.chromium.org/blink/trunk@161600 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Remove no longer flaky virtual/web-animations-css/transitions/extra-transition.html from TestExpectations

This test is not longer flaky:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=extra-transition.html

BUG=

Review URL: https://codereview.chromium.org/62383003

git-svn-id: svn://svn.chromium.org/blink/trunk@161601 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Minor optimization in FrameSelection::setNonDirectionalSelectionIfNeeded().

We can avoid a second call to newSelection.visibleExtent() by maintaining a local
variable for the same.

A call to visibleExtent() further entails computing of VisiblePosition which can
be avoided the second time round.
This change also makes it similar to the handling of newSelection.visibleBase().

Review URL: https://codereview.chromium.org/64323002

git-svn-id: svn://svn.chromium.org/blink/trunk@161602 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Move TreeBoundaryCrossingRules to its own file.

There's no benefit to it being nested inside DocumentRuleSets.
A separate file makes it easier to navigate the code.

Review URL: https://codereview.chromium.org/64443003

git-svn-id: svn://svn.chromium.org/blink/trunk@161603 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Reland: Focus changes should be use affectedBy optimization

This was reverted in https://codereview.chromium.org/61553008/
but after further investigation those flakes appear unrelated
to this change.  Relanding.

Original review by esprehn was done in:
https://codereview.chromium.org/63183004

Previously any time you hide/showed your Chrome window
we would recalcStyle on the entire document (<body> and below).

Similarly whenever you clicked on anything in Chrome
we would recalc style of the entire body (unless the caret
was already somewhere else).  For applications which don't
normally take focus, this meant a zillion extra full-document
style recalcs.

This was especially bad for applications with animation triggered
from click, as those animations would first cause a full document
style recalc before their animation could start.

I don't believe we have any way to count style recalcs in a test
so there is no good way to test this yet.  I could write a
performance microbenchmark, but that would be more like a
regression test since it just tests for the presence of this
optimization.

R=esprehn
BUG=315923

Review URL: https://codereview.chromium.org/64643007

git-svn-id: svn://svn.chromium.org/blink/trunk@161604 bbb929c8-8fbe-4397-9dbb-9b2b20218538