edit and login done