I am -1 to rush feature in a couple of days before the freeze especially when it introduces new issues. Let's fix outstanding issues first, we can live 6 more months without buttons plus an increased sw quality.

----- Reply message -----
De : "Bernhard Schussek" <notifications@github.com>
Pour : "symfony/symfony" <symfony@noreply.github.com>
Cc : "Victor Berchet" <victor@suumit.com>
Objet : [symfony] [Form] Support buttons in forms (#6528)
Date : jeu., janv. 3, 2013 18:30
In src/Symfony/Component/Form/ButtonBuilder.php:
> +    /**
> +     * Unsupported method.
> +     *
> +     * This method should not be invoked.
> +     *
> +     * @param string|integer|FormBuilderInterface $child
> +     * @param string|FormTypeInterface            $type
> +     * @param array                               $options
> +     *
> +     * @return void
> +     *
> +     * @throws \BadMethodCallException
> +     */
> +    public function add($child, $type = null, array $options = array())
> +    {
> +        throw new \BadMethodCallException('Buttons cannot have children.');

Cleaning up the exceptions in the Form component is on the TODO list.


&mdash;

Reply to this email directly or view it on GitHub.