all tests passing for string too