code convetion revised