Cool.  Thanks for the feedback!
I got the majority of these taken care of- although I have a couple
questions which I will pose to Matt tonight.  Will upload when they are all
addressed.

-s


2013/7/17 Matt T. Proud <notifications@github.com>

> In web/static/js/graph_template.handlebar:
>
> >                    <span class="opts">
> >                      <input type="checkbox" name="stacked" id="stacked{{id}}" {{stacked_checked}}>
> > -                    <label for="stacked{{id}}">Stacked</label>
> > +                    <label for="stacked{{id}}" id="graphStacked">Stacked</label>
>
> Julius, any thoughts about this:
> http://google-styleguide.googlecode.com/svn/trunk/htmlcssguide.xml? Am
> 17.07.2013 01:26 schrieb "juliusv" <notifications@github.com>:
> … <#13feb3a1ddfa3544_>
>  In web/static/js/graph_template.handlebar: > <span class="opts"> > <input
> type="checkbox" name="stacked" id="stacked{{id}}" {{stacked_checked}}> > -
> <label for="stacked{{id}}">Stacked</label> > + <label for="stacked{{id}}"
> id="graphStacked">Stacked</label> Two things about this: 1) the CSS
> class/id naming convention in Prometheus is to use under_scores, not
> camelCase (exceptions with dashes instead of underscores for jquery-ui and
> bootstrap class names). Please name this graph_stackedinstead. 2) IDs have
> to be unique within a page, but there can be many of these elements
> (multiple graphs per page), so this ID will not be unique. Make it a class
> instead. HOWEVER, how about removing this id/class altogether and changing
> the CSS rule so that they apply to all labels within the config class?
> Like: .config label { display: inline; } Similar comments apply to other
> newly introduced ID fields. — Reply to this email directly or view it on
> GitHub<https://github.com/prometheus/prometheus/pull/334/files#r5231321>
> .
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/prometheus/prometheus/pull/334/files#r5235160>
> .
>



-- 
Sabra S. Melamed
+49 170 203 8455
Stargarder Straße 48
10437 Berlin, Deutschland