ok i will refactor that part


On 14 August 2013 14:16, Aidan Shribman <notifications@github.com> wrote:

> In drivers/heca/base.c:
>
> >          if (is_svm_local(svm)) {
> > -                cancel_delayed_work_sync(&svm->delayed_gup_work);
> > +                cancel_delayed_work_sync(&svm->heca_delayed_gup_work);
>
> better that variable names are shorter (while ok that struct names are
> long)
> svm->heca_delayed_gup_work should be reverted to
> svm->delayed_gup_work ... or even
> svm->gup_job
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/hecatonchire/linux-heca/pull/33/files#r5762827>
> .
>



-- 

Dr. Benoit Hudzia

M +44 (0)79 834 46729
<benoit.hudzia@sap.com>

mailto:benoit.hudzia@gmail.com <benoit.hudzia@sap.com>