must commit pref changes