code review for dingquan