Hi Iryoku, I have taken this code from another part of the file where Byrth handles enemy weaponskills this way and re-purposed it for magic.
 
I was wondering a bit about what the null value was doing here, but as my LUA knowledge is pretty much basic at this time, I left it as is, since my testing showed it works for the end user.
I showed my code to Byrth asking for opinion, but as his laptop got fried few days ago, he won't be able to do much with FFXI. He said to just push it.
 
I'll forward him your comment as I guess it will apply to other parts of the code as well, and my knowledge is nowhere near to amend the addon as a whole.
 
Thank you for your time!
 
 
Dnia 28 czerwca 2013 23:28 IryokuChevalier &lt;notifications@github.com&gt; napisał(a):
In addons/battlemod/event_action.lua:
&gt; @@ -219,7 +219,11 @@ function event_action(act)&gt; ifT{252,265,268,269,271,272,274,275,650}:contains(msg_ID) then&gt; spell = 'MagicBurst '..spell&gt; end&gt; - spell =color_it(spell,color_arr['spellcol'])&gt; + ifactor_table['is_npc'] then&gt; + spell =color_it(spell or '',color_arr['mobspellcol'])&gt; + else&gt; + spell =color_it(spell or '',color_arr['spellcol'])I don't like this part, instead of passing an empty string to color_it if spell is nil, color_it should be modified to return an empty string if it's passed nil.
This is not bad enough to block the pull request, but this should still be addressed.
—
Reply to this email directly or view it on GitHub.