Update mock introspection for new module format

The rpmbuilder module now uses 'pl-family-version-arch' for the mock
format for both el and fedora, whereas previously it was only el that
did so. This commit is the first in steps to update the various projects
that use the packaging repo to this new format.

Signed-off-by: Moses Mendoza <moses@puppetlabs.com>
A bit more task name cleanup

pe:local_mock_final should be pe:local_mock_all to bring it in line with the
other tasks, e.g. either mock for a single build or mock_all for all targets.

Signed-off-by: Moses Mendoza <moses@puppetlabs.com>
Use same versioning across pe/foss

Before our versioning problems had been resolved, a quick workaround for PE
builds of branches with commits past a tag was to use the dot version instead
of a dash version. This isn't necessary any longer and is biting us now in
puppetdb. This commit just removes the conditional logic and uses the dash
version across foss/pe, which was the case originally.

Signed-off-by: Moses Mendoza <moses@puppetlabs.com>
Add a conditional ship location for non-release
assign @team always

We want want to assign the @team variable always in 10_setupvars, because
otherwise things get wierd during reassignment in remote tasks. There's no
reason we don't want this behavior.

Signed-off-by: Moses Mendoza <moses@puppetlabs.com>
Enable overriding ship target for PE ship on demand

Signed-off-by: Moses Mendoza <moses@puppetlabs.com>
Correct envvar name in 20_setupextras
Add comment on 20_setupextravars
Fix mock version & family introspection
Merge pull request #94 from MosesMendoza/maint/master/puppetdb_fixups

Update mock introspection for new module format