Si, personal, pero cuando se usa feature toggling (que esta técnica),
justamente de habla de preder y apagar (on/off), no se PREVENT o AVOID. Es
simplemente "la convención".

Saludos!
NicoPaez <http://nicopaez.wordpress.com/>


On Wed, Aug 28, 2013 at 4:19 PM, DiegoS <notifications@github.com> wrote:

> In models/environment/mail_notifier_config.rb:
>
> > +# - MAIL_PREVENT_NOTIFICATION_FOR:
> > +#   * If is set to 'test_result', Alfred is not sending test_result notification to students
> > +#
> > +class MailNotifierConfig
> > +
> > +  def self.has_to_prevent_notification_for( action )
> > +    stored_values(ENV['MAIL_PREVENT_NOTIFICATION_FOR']).include?( action )
> > +  end
> > +
> > +  private
> > +
> > +  VARIABLE_SEPARATOR = ','
> > +
> > +  def self.stored_values( content )
> > +    value =  content || ""
> > +    value.split(VARIABLE_SEPARATOR).collect do |value|
>
> Como yo lo veo, el flujo común es enviar la notificación. No le veo mucho
> sentido preguntar se hay que enviar, se entiende que sí. Pero entiendo que
> es muy personal. Saludos DiegoS
> … <#140c65d6971cfaa9_>
> On 28 August 2013 15:48, Nicolas Paez <notifications@github.com> wrote: >
> In models/environment/mail_notifier_config.rb: > > > +# -
> MAIL_PREVENT_NOTIFICATION_FOR: > > +# * If is set to 'test_result', Alfred
> is not sending test_result notification to students > > +# > > +class
> MailNotifierConfig > > + > > + def self.has_to_prevent_notification_for(
> action ) > > +
> stored_values(ENV['MAIL_PREVENT_NOTIFICATION_FOR']).include?( action ) > >
> + end > > + > > + private > > + > > + VARIABLE_SEPARATOR = ',' > > + > > +
> def self.stored_values( content ) > > + value = content || "" > > +
> value.split(VARIABLE_SEPARATOR).collect do |value| > > Che, me hace un poco
> de ruido que el flag pregunte si tene que "evitar" la > notificación. Creo
> que sea más conveniente ponerlo en positivo, o sea, > .should_notify_xxxx y
> en todo caso que por default sea true. Saludos! > NicoPaez <
> http://nicopaez.wordpress.com/> > … <#140c641c62873fe2_> > On Wed, Aug
> 28, 2013 at 2:07 PM, DiegoS <notifications@github.com> wrote: In
> models/environment/mail_notifier_config.rb: > +# -
> MAIL_PREVENT_NOTIFICATION_FOR: > +# * If is set to 'test_result', Alfred is
> not sending test_result notification to students > +# > +class
> MailNotifierConfig > + > + def self.has_to_prevent_notification_for( action
> ) > + stored_values(ENV['MAIL_PREVENT_NOTIFICATION_FOR']).include?( action
> ) > + end > + > + private > + > + VARIABLE_SEPARATOR = ',' > + > + def
> self.stored_values( content ) > + value = content || "" > +
> value.split(VARIABLE_SEPARATOR).collect do |value| Absolutamente! Ahí lo
> hago — Reply to this email directly or view it on GitHub<
> https://github.com/fiuba/alfred/pull/63/files#r6039342> . — Reply to this
> email directly or view it on GitHub<
> https://github.com/fiuba/alfred/pull/63/files#r6042493> .
>  -- Saludos DiegoS
> -------------------------------------------------------
> ar.linkedin.com/in/ingdiegosanchez
>
> —
>
> Reply to this email directly or view it on GitHub<https://github.com/fiuba/alfred/pull/63/files#r6043363>
> .
>
>