I am not looking at code (again/yet).
I am replying (by e-mail) to your reply (found in my e-mail Inbox) to my
last round of comments. But then when I click the "view it on GitHub" link
from the e-mail it takes me to the pull request but I don't see these
recent comments (because the discussion thread is rooted in code that you
have changed, I guess -- wonderful github).


On Fri, Oct 25, 2013 at 8:36 PM, Xin Jia <notifications@github.com> wrote:

> In src/frontend/org/voltdb/planner/PlanAssembler.java:
>
> >
> > -        scanNode.addInlinePlanNode(mvFixInfo.scanInlinedProjectionNode);
> > +        if (mvFixInfo.isJoin()) {
>
> What version of the code you are looking at?
>  - scanNode.addInlinePlanNode(mvFixInfo.scanInlinedProjectionNode); + if
> (mvFixInfo.isJoin()) {
> I assume that I have removed all the isJoin() code already.
> … <#141f2310694e47f8_>
> On Oct 25, 2013, at 8:28 PM, Paul A Martel <notifications@github.com>
> wrote: OK for now
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/VoltDB/voltdb/pull/889/files#r7232000>
> .
>