Correct factory used in product_attributes for shared "product prototype" context

Fixes broken build: https://travis-ci.org/spree/spree/jobs/4244803
Cleanup product and variant factories

Fixes #2419