On 09/04/2013 04:53 PM, Volker Adler wrote:
>
> In DataFormats/PatCandidates/interface/Muon.h:
>
> > @@ -83,9 +80,20 @@
> >        reco::TrackRef combinedMuon() const;
> >        /// reference to Track reconstructed in both tracked and muon detector (reimplemented from reco::Muon)
> >        reco::TrackRef globalTrack() const { return combinedMuon(); }
> > +      /// reference to the Best Track reconstructed in both tracked and muon detector (reimplemented from reco::Muon), old (default bt deprecated) tuneP
> > +      reco::TrackRef muonBestTrack();
> > +      /// reference to the Best Track reconstructed in both tracked and muon detector (reimplemented from reco::Muon), after new tuneP
> > +      reco::TrackRef improvedMuonBestTrack();
>
> @bellan <https://github.com/bellan>
> I have made my proposal available as vadler/53X-muonSelectorsFix. 
> Could you take a look, please?
> Since the "set(Improved)BestTrack" functions are called in the 
> PATMuonProducer /in any case/ now, the result might be even more 
> consistent.(?)
> The attached plot besttracktype 
> <https://f.cloud.github.com/assets/4622453/1081134/b730d57c-1571-11e3-8e0b-31ae5a7fcc17.png> 
> shows the 'bestTrackType' data member in a) blue from your original 
> commit and in b) red from my proposal. The 'bestImprovedTrackType' 
> remains identical for both (produced with 
> PhysicsTools/PatAlgos/test/patTuple_onlyMuons_cfg.py).
>
I am a bit surprised about the plot (blue one), as I get (that was the 
fix) no more zeroes. Are you sure you did not swapped the two? Also 
vadler:53X-muonSelectorsFix as a tons of other stuff in it, nothing to 
do with muons, can you give me a polished version? (that I think we have 
to provide anyhow, otherwise we go back to the problem you and Slava arose).

A part that, I assume you just touched  pat::Muon.h/cc and 
PATMuonProducer.cc to move the setBestType (as far as I can see making a 
diff of these files). In general your proposal could be fine, it remains 
to sort out the outcome of your test, though.




> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/cms-sw/cmssw/pull/684/files#r6155757>.
>