Great - I was hoping that was true!

We didn't add any code to handle ESC because it is handled by bootstrap (or jquery?). They just ask that you set tabindex=-1 on the element if you want that behavior. We did add code to handle Space and Enter - and the space handler has preventDefault() to keep the browser from scrolling (similar to what you are doing with Escape)

> On Nov 25, 2013, at 9:19 AM, Brandon Bloom <notifications@github.com> wrote:
> 
> In app/assets/javascripts/application.js.erb:
> 
> > @@ -17,6 +17,16 @@
> >  // Loads all Bootstrap javascripts
> >  //= require bootstrap
> >  
> > +var KEY_ESCAPE = 27;
> I tested that specifically, it works as expected. This occurs at the document level and keydown in bubbling, not tunneling. The dialog code will get its chance to handle escape first.
> 
> However, can you point me towards the relevant code? It probably should have the preventDefault and stopPropagation calls.
> 
> —
> Reply to this email directly or view it on GitHub.