Changed Assert\MinLength to Assert\Length in doc
Fixed brace and spaces
Replace individual test suite component checks with global one
merged branch igorw/vendor-check (PR #626)

This PR was merged into the master branch.

Commits
-------

3a5d992 Replace individual test suite component checks with global one

Discussion
----------

Replace individual test suite component checks with global one

---------------------------------------------------------------------------

by davedevelopment at 2013-02-09T19:43:06Z

:+1: nice to see code disappearing
Ported ConstraintValidatorFactory.php to Silex/Pimple
[docs] Add code examples for PUT and DELETE routes
Remove the "show" verb from example routes names

This changes all examples from /blog/show/{id} to /blog/{id}. This makes
more sense in terms of HTTP, since the HTTP methods are the verbs and
the URL represents a resource.
merged branch igorw/route-no-verbs (PR #630)

This PR was merged into the master branch.

Commits
-------

1e2655f Remove the "show" verb from example routes names

Discussion
----------

[docs] Remove the "show" verb from example routes names

This changes all examples from /blog/show/{id} to /blog/{id}. This makes
more sense in terms of HTTP, since the HTTP methods are the verbs and
the URL represents a resource.
merged branch igorw/put-delete-example (PR #629)

This PR was merged into the master branch.

Commits
-------

e055ed3 [docs] Add code examples for PUT and DELETE routes

Discussion
----------

[docs] Add code examples for PUT and DELETE routes
merged branch spectralsun/master (PR #617)

This PR was merged into the master branch.

Commits
-------

ef85340 Fixed brace and spaces
6ec1153 Changed Assert\MinLength to Assert\Length in doc

Discussion
----------

Removed Assert\minLength in doc

Changed to Assert\Length

---------------------------------------------------------------------------

by igorw at 2013-02-05T00:10:22Z

For the record, this change is due to Assert\MinLength and MaxLength being deprecated in 2.1, in favour of Length.

---------------------------------------------------------------------------

by igorw at 2013-02-05T00:16:47Z

:+1:

---------------------------------------------------------------------------

by fabpot at 2013-02-07T11:22:31Z

As we still support 2.1 and 2.2, I would suggest to add a note to indicate the name of the constraint in 2.1.

---------------------------------------------------------------------------

by igorw at 2013-02-11T14:23:51Z

@fabpot Length is already available in 2.1. There is no reason not to use it already. This PR looks good to me.
[Application] fix typo
merged branch vicb/fixtypo (PR #631)

This PR was merged into the master branch.

Commits
-------

829c808 [Application] fix typo

Discussion
----------

[Application] fix typo
Enable logger and stopwatch for Doctrine queries
merged branch GromNaN/dbal-logger (PR #632)

This PR was merged into the master branch.

Commits
-------

fbffc2b Enable logger and stopwatch for Doctrine queries

Discussion
----------

Add logger and stopwatch for Doctrine queries

Add SQL queries to the logs using the DbalLogger of the DoctrineBridge.

In addition, if the WebprofilerServiceProvider is registered (stopwatch service set), the timeline show doctrine queries.

![Profiler](https://f.cloud.github.com/assets/400034/152414/877dc396-75c4-11e2-96df-6dde93c7d86e.png)

---------------------------------------------------------------------------

by DerManoMann at 2013-02-13T10:37:42Z

:+1:

---------------------------------------------------------------------------

by fabpot at 2013-02-13T10:39:34Z

I'm wondering if the stopwatch service should be moved to Silex core.

---------------------------------------------------------------------------

by lyrixx at 2013-02-13T11:05:00Z

Totally :+1: for moving it to silex.

---------------------------------------------------------------------------

by GromNaN at 2013-02-13T11:16:20Z

Is there a use case for the "stopwatch" outside of the webprofiler ?

---------------------------------------------------------------------------

by lyrixx at 2013-02-13T11:23:44Z

@GromNaN Yes, it you want to bench some code.

---------------------------------------------------------------------------

by henrikbjorn at 2013-02-13T11:35:28Z

@fabpot please not it will only add cruft. i think it is a niche thing to use the Stopwatch component.
- Type hint in Silex\ConstraintValidatorFactory constructor for container
- Modifed Silex\Provider\ValidatorServiceProvider to accept an optional
  'validator.validator_service_ids' parameter wich allows users to register
  custom validators.
- Added test to verify that if users registered ValidatorServiceProvider
  using optional 'validator.validator_service_ids' parameter then the new
  Silex\ConstraintValidatorFactory will be used instead of the one provided
  in  Symfony.
proper prefixes for cookie options
improved the performance of the Twig loader by not registering a chain loader if not needed
merged branch fabpot/twig-perf (PR #635)

This PR was merged into the master branch.

Commits
-------

7e554db improved the performance of the Twig loader by not registering a chain loader if not needed

Discussion
----------

improved the performance of the Twig loader by not registering a chain loader if not needed

When `twig.templates` is empty, there is no need to register the Twig array loader as it will never be used anyway.

---------------------------------------------------------------------------

by lyrixx at 2013-02-18T09:50:07Z

totally :+1: More over, I think this feature was not documented.

---------------------------------------------------------------------------

by GromNaN at 2013-02-18T10:04:32Z

Nice tip. How much is it more performant ?

@lyrixx it is documented here : http://silex.sensiolabs.org/doc/providers/twig.html#parameters

---------------------------------------------------------------------------

by fabpot at 2013-02-18T10:06:17Z

It's not really about how much but just keeping the array loader around is a waste of time.

---------------------------------------------------------------------------

by igorw at 2013-02-18T13:37:58Z

:-1: This prevents extending the `twig.loader` service and also feels like a micro-optimization to me.

---------------------------------------------------------------------------

by fabpot at 2013-02-18T13:57:13Z

I've removed the optimization but I've kept the different order in registration as it makes more sense.

---------------------------------------------------------------------------

by igorw at 2013-02-18T13:59:55Z

:+1:
Updated docs to include _method and enableHttpMethodParameterOverride()
merged branch robdudley/master (PR #636)

This PR was squashed before being merged into the master branch (closes #636).

Commits
-------

abdc1fc Updated docs to include _method and enableHttpMethodParameterOverride()

Discussion
----------

Updated docs to include _method and enableHttpMethodParameterOverride()

Should be self explanatory. Small addition to the docs to explain about the _method form value and also to advise abut the explicit enableHttpMethodParameterOverride() call required with Symfony 2.2.0 and later.

---------------------------------------------------------------------------

by igorw at 2013-02-18T13:57:37Z

Please wrap the docs at 80 chars.

:+1:

---------------------------------------------------------------------------

by davedevelopment at 2013-02-18T14:02:08Z

:+1:

Only one thing, do we need to explicitly state to do this before the request is handled? No-brainer to us, but what about others?

Or should I say, how likely are people to try and do something like:

``` php

$app->put("/some/resource", function(Request $request) {
    Request::enableHttpMethodParameterOverride();
});

```

---------------------------------------------------------------------------

by robdudley at 2013-02-18T14:11:15Z

I've used a similar example to the reverse proxy tip which I hope would make the context clear. Not sure how else to word it without becoming unnecessarily verbose. Also I'm assuming that the setting is going to be rolled into core at some point as it has pretty big backwards compatibility implications.

---------------------------------------------------------------------------

by davedevelopment at 2013-02-18T14:14:00Z

:shipit: