updated tests with edgecases