Week 33

Layout Tests:
  * Refactor a Layout Test which tests two contexts using the same device.
  * New Layout Test: Image Object.
2013-08-14  Sharath Kamath  <s.kamath@samsung.com>

        Fix WebCLMemoryObject::getInfo(MEM_ASSOCIATED_MEMOBJECT)
        Issue #275

        Reviewed by Antonio.

        As per OpenCL specification [http://www.khronos.org/registry/cl/sdk/1.2/docs/man/xhtml/clGetMemObjectInfo.html]
        Return memory object from which memobj is created.
        This returns the memory object specified as buffer argument to clCreateSubBuffer.
        Otherwise a NULL value is returned.

        So we need to store the parent WebCLMemoryObject when creating each sub-buffer.

        Also removing the extra buffertype parameter added by commit 115a8389369bb00240eca6dfd54ccee77158a651
        as the same m_parentBuffer can be used for the same.

        conformance/computeinfo/cl_memoryObject_getinfo.html
        conformance/buffimgs/cl_buffer_createSubBuffer.html
        [https://github.com/SRA-SiliconValley/webkit-webcl-conformance]

        * Modules/webcl/WebCLBuffer.cpp:
        (WebCore::WebCLBuffer::WebCLBuffer):
        (WebCore::WebCLBuffer::createSubBuffer):
        * Modules/webcl/WebCLBuffer.h:
        * Modules/webcl/WebCLMemoryObject.cpp:
        (WebCore::WebCLMemoryObject::WebCLMemoryObject):
        (WebCore::WebCLMemoryObject::getInfo):
        * Modules/webcl/WebCLMemoryObject.h:
2013-08-21  Sharath Kamath  <s.kamath@samsung.com>

        Delete window.WebCL property as this must not be exposed to JS.
        Issue #257

        Reviewed by Antonio.

        As a singleton object is exposed to JS via window.webcl we must not
        expose WebCL interface to WebCL.
        Adding "NoInterfaceObject" in WebCL.IDL.

        No new tests (OOPS!).

        * Modules/webcl/WebCL.idl:
2013-08-23  Antonio Gomes  <a1.gomes@sisa.samsung.com>

        Use JSDictionary class instead of parsing WebCLContextProperties manually
        Issue #282

        Reviewed by Igor.

        Other classes like HTMLCanvasElement and Geolocation
        use JSDictionary to parse their dictionary-like object parameters.
        Patch makes our implementation to follow the same way. In practice,
        there should be no behavior difference, though.

        No new tests (OOPS!).

        * Modules/webcl/WebCLContextProperties.cpp:
        (WebCore::WebCLContextProperties::create):
        Added a overload method that takes no parameter.

        (WebCore::WebCLContextProperties::WebCLContextProperties):
        Added a default constructor, that takes no parameters.

        (WebCore::WebCLContextProperties::setDevices):
        (WebCore::WebCLContextProperties::webGLRenderingContext):
        (WebCore::WebCLContextProperties::setWebGLRenderingContext):
        Methods added to match the other class members' getters and setters.

        (WebCore::WebCLContextProperties::deviceType):
        Changed the return type from int to unsigned long, as per the spec.

        (WebCore::WebCLContextProperties::setDeviceType):
        Changed the parameter type from int to unsigned long, as per the spec.

        * Modules/webcl/WebCLContextProperties.h:
        * Modules/webcl/WebCLContextProperties.idl:
        Fixed 'deviceType' declaration type from int to unsigned CLenum, as per the spec.

        * bindings/js/JSDictionary.cpp:
        (WebCore::JSDictionary::convertValue):
        * bindings/js/JSDictionary.h:
        Add support for acquiring WebCL and WebGL pecific object types:
        WebCLPlatform, Vector<WebCLDevice> and WebGLRenderingContext.

        * bindings/js/JSWebCLCustom.h:
        (WebCore::setPlatform):
        (WebCore::setDevices):
        (WebCore::setDeviceType):
        (WebCore::setSharedContext):
        Helper setter methods.

        (WebCore::parsePropertiesAndCreateContext):
        Make use of JSDictionary to parse dictionary-like objects.
2013-08-23  Antonio Gomes  <a1.gomes@sisa.samsung.com>

        Unreviewed WebCLImageDescriptor files clean up.

        * Modules/webcl/WebCLImageDescriptor.cpp:
        (WebCore::WebCLImageDescriptor::create):
        (WebCore::WebCLImageDescriptor::WebCLImageDescriptor):
        * Modules/webcl/WebCLImageDescriptor.h:
        * Modules/webcl/WebCLImageDescriptor.idl:
2013-08-23  Antonio Gomes  <a1.gomes@sisa.samsung.com>

        Use JSDictionary class instead of parsing WebCLImageDescriptor manually
        Issue #289

        Reviewed by Igor.

        Other classes like HTMLCanvasElement and Geolocation
        use JSDictionary to parse their dictionary-like object parameters.
        Patch makes our implementation to follow the same way. In practice,
        there should be no behavior difference, though.

        WebCLImageDescriptor also got its types changed to
        match the spec.

        * Modules/webcl/WebCLImageDescriptor.cpp:
        (WebCore::WebCLImageDescriptor::setWidth):
        (WebCore::WebCLImageDescriptor::width):
        (WebCore::WebCLImageDescriptor::setHeight):
        (WebCore::WebCLImageDescriptor::height):
        (WebCore::WebCLImageDescriptor::setRowPitch):
        (WebCore::WebCLImageDescriptor::rowPitch):
        * Modules/webcl/WebCLImageDescriptor.h:
        * Modules/webcl/WebCLImageDescriptor.idl:
        * bindings/js/JSDictionary.cpp:
        (WebCore::JSDictionary::convertValue):
        * bindings/js/JSDictionary.h:
        * bindings/js/JSWebCLContextCustom.cpp:
        (WebCore::setChannelOrder):
        (WebCore::setChannelType):
        (WebCore::setWidth):
        (WebCore::setHeight):
        (WebCore::setRowPitch):
        (WebCore::JSWebCLContext::createImage):
2013-08-24  Antonio Gomes  <a1.gomes@sisa.samsung.com>

        computeinfo/cl_device_getinfo.html fails
        Issue #290

        Reviewed by TrustMe.

        After bug 815 (DEVICE_MAX_CONSTANT_ARGS is not listed as a valid
        infoType for WebCLDevice::getInfo) got fixed, we can include
        DEVICE_MAX_CONSTANT_ARGS as a valid parameter in WebCLInputChecker::isValidDeviceInfoType

        [1] http://www.khronos.org/bugzilla/show_bug.cgi?id=815

        Fixes conformance test computeinfo/cl_device_getinfo.

        * Modules/webcl/WebCL.idl:
        * Modules/webcl/WebCLInputChecker.cpp:
        (WebCore::WebCLInputChecker::isValidDeviceInfoType):
2013-08-02  Marcelo Morais  <m.morais@samsung.com>

        Declaring GLint type on GraphicsContext3D.
        Issue #196

        Reviewed by Antonio Gomes.

        This type wasn't declared for EFL platform and it is needed by
        the fix of Issue #241. Without this, the EFL build won't work.

        * platform/graphics/GraphicsContext3D.h:
2013-08-13  Marcelo Morais  <m.morais@samsung.com>

        Removing unnecessary initialization in template.
        Issue #196

        Reviewed by Antonio Gomes.

        The initialization in templates behave differently in clang (Mac)
        and g++(Linux). Without this, the efl linux port won't build.

        * platform/ComputeTypesTraits.h:
Week 34

Fix build-webkit --no-webcl to disable WebCL build
  * https://github.com/SRA-SiliconValley/webkit-webcl/issues/281

Layout Tests:
  * New Layout Test: Interoperability with Texture