ok adding a test for this