nit: we should use enums/constants