On 08/12/2013 11:19 AM, Jason L Connor wrote:
> In platform/src/pulp/server/managers/consumer/applicability.py:
> 
>>  
>> -_LOG = getLogger(__name__)
> 
> Just wondering why you changed the name of this. I tend to use all caps
> for things that are constants and a proceeding '_' for things that
> should not be exported from the module. It doesn't really matter, but I
> (personally) liked the old name better.

I don't like _LOG because it isn't actually a constant as it's an
object. logger is a good name in my opinion, since it's an instance of a
logger. To your point, I do think it would have been more reasonable for
me to name it _logger instead of logger.

-- 
Randy Barlow
Raleigh, NC, USA