Pre-emptively create the other two hash tables in packet.c for simplicity's
sake.

svn path=/trunk/; revision=51355
Nowhere in the RFC's (793 or otherwise) does it indicate that if the URG bit is not set that the urgent pointer field must be zero.

References:
http://tools.ietf.org/html/rfc793, http://tools.ietf.org/html/rfc1122, ...
http://www.wireshark.org/lists/ethereal-dev/200307/msg00297.html

Similarly, nowhere does it say that the acknowledgment number field must be zero if the ACK bit is not set.

This patch effectively reverts r37721.  If non-zero urgent pointers are of interest to you when the URG bit is not set, then a filter such as follows can be used:

    (tcp.flags.urg == 0) && !(tcp[18:2] == 00:00)

Similarly, if non-zero acknowledgment numbers are of interest to you when the ACK bit is not set, then use this filter:

    (tcp.flags.ack == 0) && !(tcp.ack == 0)

For consistency, should we avoid adding the ack field in this case as well?  The above filter would then change to:

    (tcp.flags.ack == 0) && !(tcp[8:4] == 00:00:00:00)

This change was prompted by the following question on ask.wireshark.org:
http://ask.wireshark.org/questions/23753/tcp-urgent-pointer-value-not-displayed

svn path=/trunk/; revision=51356
Add some XXX comment.

svn path=/trunk/; revision=51358
use the correct length for the tvbuff of an unknown usb descriptor

svn path=/trunk/; revision=51359
As suggested by Volcke Mario, fixing
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9036

Don't change the length *and* the offset when adjusting for the ethercat header,
just the offset is enough (the length is then right).

svn path=/trunk/; revision=51360
From Tyson Key via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9037

Update the heuristics for detecting ISO 14443-A payloads with 4 byte UIDs, and
ATS values to support MTCOS-based cards/tokens (e.g. passports) in PN532
InListPassiveTarget responses.

svn path=/trunk/; revision=51361
From Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9040

Small fixes and enhancements to SCSI INQUIRY results.

svn path=/trunk/; revision=51362
Free the old name before we add the new one in case the services file has
duplicates (it does). Fixes about 2KB of leaks.

svn path=/trunk/; revision=51363
Split the code to convert an ethernet address into an int64 into a function
since it's used in several places. Don't allocate a key just to do a hash-table
lookup, we only need to do that if we're actually inserting. Fixes another ~1KB
of leaks.

svn path=/trunk/; revision=51364
A few more improvements:
1. Make a "dissect_dictionary" function for the common dissection of the different primary header versions.
2. Remove some of the "dissection aborts" if sdnv values are bad.  Detecting malformed packets can be a good thing.
3. Make fields that use a sdnv value filterable, with expert info if the value is bad.


svn path=/trunk/; revision=51365
Add SVN properties to expand $Id$ and use native line endings.

svn path=/trunk/; revision=51366
Expand $Id$, use native line endings, get rid of CRs (they belong on
Windows, but not on UN*X).

svn path=/trunk/; revision=51368
Expand $Id$, use native line endings.

svn path=/trunk/; revision=51369
Fix $Id$

svn path=/trunk/; revision=51372
Fix $Id$.

svn path=/trunk/; revision=51373
Add $Id$.

svn path=/trunk/; revision=51376
Add $Id$, arrange that it's expanded, use native line endings.

svn path=/trunk/; revision=51378
Add $Id$, arrange that it's expanded, use native line endings.

svn path=/trunk/; revision=51379
Get rid of set-but-not-used variable.  Link to the tools.ietf.org HTML
version of RFC 5050.

svn path=/trunk/; revision=51380