revisit some code