Ill review.

On Feb 19, 2013 4:49 PM, "Robert Carlsen" <notifications@github.com> wrote:
>
> In src/Core/Utility/SqliteDb.cpp:
>
> > +        char * ptr = (char*)sqlite3_column_text(statement, col);
> > +        if(ptr) {
> > +          val = ptr;
> > +        } else {
> > +          val = "";
> > +        }
> > +        values.push_back(val);  // now we will never push NULL
> > +      }
> > +      results.push_back(values);
> > +    }
> > +    sqlite3_finalize(statement);
> > +  }
> > +
> > +  // collect errors
> > +  std::string error = sqlite3_errmsg(db_);
> > +  if(error != "not an error") {
>
> It looks like Matt did it to avoid dual calls to sqlite3_errcode and
sqlite3_errmsg. I think I'll change it to do the sqlite3_errcode(db_) ==
SQLITE_OK first - unless @gidden is aware of a problem that makes it not
work.
>
> —
> Reply to this email directly or view it on GitHub.