added todo for better config of supported share types