Right, `return` in `ensure` is a very weird beast.  If no tests fail, I'd say feel free to refactor it to something more reasonable.  I don't know the history behind it -- this matcher predates my time working on rspec by many years.