Alright, I've updated it in my commits on master and 1-3-stable to use
blank instead. We're just fiddling with the CI server at the moment (moving
it to a faster box) and so once we're done with that and everything's green
again, it'll be on spree/spree.


On Wed, Feb 27, 2013 at 10:35 AM, Jeff Dutil <notifications@github.com>wrote:

> In core/app/models/spree/calculator/per_item.rb:
>
> > @@ -14,7 +14,7 @@ def self.description
> >      def compute(object=nil)
> >        return 0 if object.nil?
> >        self.preferred_amount * object.line_items.reduce(0) do |sum, value|
> > -        if !matching_products || matching_products.include?(value.product)
> > +        if matching_products.nil? || matching_products.empty? || matching_products.include?(value.product)
>
> I thought I had tried that and a couple specs failed, but thinking back on
> it I had simply tried to do #empty? which didn't work as expected since
> empty didn't handle nil. Will update now since I definitely prefer blank?
> over nil? and empty?.
>
> Was probably just in need of coffee at the time...
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/spree/spree/pull/2610/files#r3172258>
> .
>