Refactor MinisterialRolesController and add cucumber tests

The refactoring makes the behaviour clearer.

Added better test coverage in the cucumber tests as there were no tests
covering the index pages.