Just doubts if you feel confident, then I have no objections.
Il giorno 17/ago/2013 20:17, "niphlod" <notifications@github.com> ha
scritto:

> In gluon/main.py:
>
> > -    if profilerfilename and exists(profilerfilename):
> > -        os.unlink(profilerfilename)
> > -    locker = allocate_lock()
> > +
> > +    if profiler_dir:
> > +        profiler_dir = abspath(profiler_dir)
> > +        logger.warn('profiler is on. will use dir %s', profiler_dir)
> > +        if not os.path.isdir(profiler_dir):
> > +            try:
> > +                os.makedirs(profiler_dir)
> > +            except:
> > +                raise BaseException, "Can't create dir %s" % profiler_dir
> > +        filepath = pjoin(profiler_dir, 'wtest')
> > +        try:
> > +            filehandle = open( filepath, 'w' )
> > +            filehandle.close()
>
> uhm. in a finally I'd still have to check if unlink raises an exception
> because of the file not found. usually either you can write to a folder
> (and so, to delete) or it is in read-only, and in that case the exception
> is raised on the open().
> As for the random part appended to the wtest, what assurance does it bring
> ?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/web2py/web2py/pull/170/files#r5829495>
> .
>