Good point, sorry, didn't think this through very hard


On Fri, Jul 26, 2013 at 4:40 PM, Daniel Roberts <notifications@github.com>wrote:

> In corehq/apps/app_manager/static/app_manager/js/detail-screen-config.js:
>
> > @@ -151,7 +151,7 @@ var DetailScreenConfig = (function () {
> >          return orig;
> >      }
> >
> > -    var field_val_re = /^[a-zA-Z][\w_-]*(\/[a-zA-Z][\w_-]*)*$/;
> > +    var field_val_re = /^[a-zA-Z][\w_:/-]*(\/[a-zA-Z][\w_:/-]*)*$/;
>
> [a-zA-Z][\w_-]* is my way of saying "a word that starts with a letter".
> If I replace it with {word} for clarity you get {word}(\/{word})* meaning
> a word and then any number of words with slashes before them. I feel like
> it should be changed to ({word}:)?{word}(\/{word})*, because that's
> tighter. (I.e. it would disallow something like a/b:c/d:e, since a slash
> before a colon isn't allowed and multiple colons isn't allowed.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dimagi/commcare-hq/pull/751/files#r5423897>
> .
>



-- 
Simon Kelly
Senior Engineer | Dimagi South Africa