Got it, also I'm still thinking what could be a good expectation for this.
Parting from the fact that this is an integration test I'm thinking in
asserting side effects doing some should receive type of assertions. What
do you guys think?
On Oct 23, 2013 5:41 PM, "Dan Kubb" <notifications@github.com> wrote:

> In lib/devtools/tasks/flay.rb:
>
> > +
> > +    class Flay
> > +
> > +      attr_reader :config, :project, :files
> > +      def initialize(config, project)
> > +        @config = config
> > +        @project = project
> > +        @files = ::Flay.expand_dirs_to_files(project.lib_dir).sort
> > +      end
> > +
> > +      def call
> > +        # Run flay first to ensure the max mass matches the threshold
> > +        flay = run_flay
> > +
> > +        max = (masses(flay).max || 0).to_i
> > +        unless max >= threshold
>
> I suppose this could be stated as if max < threshold. I think I wrote the
> original code, but I have no idea why I wrote it that way. I try to specify
> things in the positive rather than the negative. I also try to minimize
> double negatives.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rom-rb/devtools/pull/44/files#r7172847>
> .
>