[ticket/10820] Image downloader recognize new version of ie
When a user download image attachement using ie8, the file is displayed.
However, when he uses ie version greater than 8, the image is download.
A changes are made to phpbb/download/file.php to solve the problem.
We check now if the ie version is greater or equal to 8 and not only equal
to 8

PHPBB3-10820
[ticket/10820] proper usage of global and local variable browser

PHPBB3-10820
[ticket/10820] fix IE check function

Add phpbb_ prefix to function name and return boolean value.

PHPBB3-10820
[ticket/10820] add function docblock

PHPBB3-10820
[ticket/10820] remove unnecessary condition checks

PHPBB3-10820
[ticket/10820] Use singular return

PHPBB3-10820
[ticket/10820] simplify regex and escape dot

PHPBB3-10820
[ticket/10820] add param and return to function

Add param and return in function docblock. Rename function
parameter to $user_agent.

PHPBB3-10820
[ticket/10820] fix docblock

PHPBB3-10820
[ticket/10820] remove unnecessary parentheses

PHPBB3-10820
Merge remote-tracking branch 'dhruvgoel92/ticket/10820' into ticket/10820-develop

* dhruvgoel92/ticket/10820:
  [ticket/10820] remove unnecessary parentheses
  [ticket/10820] fix docblock
  [ticket/10820] add param and return to function
  [ticket/10820] simplify regex and escape dot
  [ticket/10820] Use singular return
  [ticket/10820] remove unnecessary condition checks
  [ticket/10820] add function docblock
  [ticket/10820] fix IE check function
  [ticket/10820] proper usage of global and local variable browser
  [ticket/10820] Image downloader recognize new version of ie

Conflicts:
	phpBB/download/file.php
[ticket/10820] add unit tests for phpbb_is_greater_ie7

PHPBB3-10820
[ticket/10820] Add test cases

PHPBB3-10325
[ticket/10820] fix regex
Extract IE version from user agent string and then compare it with 7

PHPBB3-10820
Merge branch 'ticket/10820' into ticket/10820-develop

* ticket/10820:
  [ticket/10820] fix regex Extract IE version from user agent string and then compare it with 7

Conflicts:
	phpBB/download/file.php
[ticket/11579] Add basic set of unit tests for validate_data()

This currently includes tests for the string, num, date, match, and
language iso validation functions.

PHPBB3-11579
[ticket/11579] Add remaining unit tests for validate_data functions

This now includes tests for usernames, passwords, emails, and jabber
addresses. A few small changes had to be applied to phpbb_mock_cache
and phpbb_mock_user in order to incorporate needed methods.

PHPBB3-11579
[ticket/11579] Remove unnecessary globals from validate_password()

The globals $db and $user are not used in that function.

PHPBB3-11579
[ticket/11579] Move tests into seperate files depending on needed fixture

PHPBB3-11579
[ticket/11579] Use test case helper class and use assert prefix for method

PHPBB3-11579