up codeing style 2