Cool.  We'll need to of course write a full set of coding standards (tabs
vs spaces, bracket locations, switch conventions, etc), but until then we
should just point out anything that we dislike and see if we can agree on a
central way of doing things.


On Tue, Nov 12, 2013 at 11:13 AM, carsondk <notifications@github.com> wrote:

> In src/WelcomeState.as:
>
> > +			_multiButton = new Button(Texture.fromColor(100, 40, 0xFFFFFFFF), "Multi-player");
> > +			_multiButton.pivotX = _soloButton.width / 2;
> > +			_multiButton.x = stage.stageWidth / 2;
> > +			_multiButton.y = 400;
> > +			addChild(_multiButton);
> > +			
> > +			_soloButton.addEventListener(Event.TRIGGERED, solo_start);
> > +			_multiButton.addEventListener(Event.TRIGGERED, multi_start);
> > +		}
> > +		
> > +		protected function solo_start(e:Event):void {
> > +			trace("Start a solo game");
> > +			CitrusEngine.getInstance().state = new PongGameState();
> > +		}
> > +		
> > +		protected function multi_start(e:Event):void {
>
> I'm fine with camelCase, My ruby mind took over when I wrote the functions
> :)
> … <#1424d4d71ae9dcd5_>
> On Tue, Nov 12, 2013 at 6:41 AM, ryan-mcdonald <notifications@github.com>wrote:
> In src/WelcomeState.as: > + _multiButton = new
> Button(Texture.fromColor(100, 40, 0xFFFFFFFF), "Multi-player"); > +
> _multiButton.pivotX = _soloButton.width / 2; > + _multiButton.x =
> stage.stageWidth / 2; > + _multiButton.y = 400; > + addChild(_multiButton);
> > + > + _soloButton.addEventListener(Event.TRIGGERED, solo_start); > +
> _multiButton.addEventListener( Event.TRIGGERED, multi_start); > + } > + > +
> protected function solo_start(e:Event):void { > + trace("Start a solo
> game"); > + CitrusEngine.getInstance().state = new PongGameState(); > + } >
> + > + protected function multi_start(e:Event):void { More snake_case. —
> Reply to this email directly or view it on GitHub<
> https://github.com/Not-Robot/pong-citrus/pull/1/files#r7593305> .
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Not-Robot/pong-citrus/pull/1/files#r7598822>
> .
>



-- 

Viking