I've been operating under the influence of
https://fuhm.net/super-harmful/for a while. Mind if we leave it alone?


On Thu, Nov 14, 2013 at 3:52 PM, David Warde-Farley <
notifications@github.com> wrote:

> In hyperopt/base.py:
>
> > +    # TODO: Merge with Bandit -- two classes are not necessary
> > +    rec_eval_print_node_on_error = False
> > +
> > +    def __init__(self, fn, expr,
> > +                 workdir=None,
> > +                 pass_expr_memo_ctrl=None,
> > +                 **bandit_kwargs):
> > +        self.cmd = ('domain_attachment', 'FMinIter_Domain')
> > +        self.fn = fn
> > +        if pass_expr_memo_ctrl is None:
> > +            self.pass_expr_memo_ctrl = getattr(fn,
> > +                                               'fmin_pass_expr_memo_ctrl',
> > +                                               False)
> > +        else:
> > +            self.pass_expr_memo_ctrl = pass_expr_memo_ctrl
> > +        Bandit.__init__(self, expr, do_checks=False, **bandit_kwargs)
>
> super(Domain, self) rather than Bandit will simplify things later if the
> names change.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/hyperopt/hyperopt/pull/166/files#r7673011>
> .
>