Thanks for the feedback, I'm working on the issues you mention (with the exception of testing x-www-form-urlencoded - that's dead code and not used anywhere).

RE routes like "/compare/:commit/:commit2" not working - I just wanted to verify you wanted me to change it to mimic the JS implementation. The JS implementation wouldn't work on routes like "/modify:type" (no slash before the colon) but perhaps that is not an issue. Currently, the Android version behaves exactly like the iOS version, but I can change it to mimic the JS version no problem.

On Sep 24, 2013, at 9:00 AM, Miroslav Bajtoš <notifications@github.com> wrote:

> In android/StrongLoopRemoting/src/com/strongloop/android/remoting/adapters/RestContract.java:
> 
> > +    public String getUrl(String pattern, 
> > +    		Map<String, ? extends Object> parameters) {
> > +        if (pattern == null) {
> > +            throw new IllegalArgumentException("Pattern cannot be null");
> > +        }
> > +
> > +        String url = pattern;
> > +        if (parameters == null) {
> > +            return url;
> > +        }
> > +        
> > +        for (Map.Entry<String, ? extends Object> entry : 
> > +        	parameters.entrySet()) { 
> > +            String key = ":" + entry.getKey();
> > +            String value = String.valueOf(entry.getValue());
> > +            url = url.replace(key, value);
> This does not work correctly, consider this route: /compare/:commit/:commit2
> 
> You should split the string on / character and replace items that have value equal to the key. See Javascript implementation.
> 
> —
> Reply to this email directly or view it on GitHub.
>