:x: I'm being summoned to another house! You're right though, it passes
even with fake url, with HTTP_OK status..! I'll work on it when I return.

Thanks man!


On 25 December 2013 15:49, Antonio Bertucci <notifications@github.com>wrote:

> In core/src/test/java/uk/co/ataulm/mijur/core/api/ImgurShould.java:
>
> >      }
> >
> >      @Test
> > -    public void return_a_useable_gallery_model_given_valid_parameters() throws Exception {
> > -        Gallery gallery = Imgur.getGalleryWith(Gallery.Section.TOP, Gallery.Sort.VIRAL, 1);
> > -
> > -        assertTrue(gallery.size() > 0);
> > +    public void allow_jpg_extensions_for_gif_images() throws Exception {
>
> Did you tried to make this test red first? I'm pretty sure you can get an
> error response (ie: 404) with a correct InputStream. You should check the
> type of response somehow.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ataulm/mijur/pull/20/files#r8551186>
> .
>