Big clean up of legacy non-namespaced flakiness dashboard code.

-Move all the builders methods into the builders namespace.
-Move a bunch of things from dashboard_base to the new results
namespace.
-Move a $ and partial into base.js. I don't think these belong
in a namespace since a big benefit of them is having a short
name.
-Make some private methods not be on the namespace. Since they're
wrapped in an anonymous function, they actually are private
with respect to any code outside the namespace.
-Rename a bunch of local variables to not conflict with the
results namespace.

R=jparent@chromium.org

Review URL: https://codereview.chromium.org/16427004

git-svn-id: svn://svn.chromium.org/blink/trunk@152045 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Text-only changes shouldn't cause repaints unless there is actually text.

This is a merge of an excellent patch by akling@apple.com: wkrev.com/150259

This patch adds a new StyleDifferenceRepaintIfText value to the repertoire of
RenderStyle::diff(). This result means that the renderer only needs to repaint
if one of its immediate children contains text. This lets us avoid repainting
the same pixels when hovering over constructs like:
 <style>
  a { text-decoration: none; }
  a:hover { text-decoration: underline; }
 </style>
 <a href="http://is.gd/andersca">
  <img src="cool-hat.jpg">
 </a>
Since the change in text-decoration has no effect on the rendering of the
<img> element, we'll now be smart enough to avoid repainting it.

Note: this patch contains one modification from the original: In RenderBox I've used:
(diff == StyleDifferenceRepaint || diff == StyleDifferenceRepaintIfText || diff == StyleDifferenceRepaintLayer)
instead of:
(diff >= StyleDifferenceRepaint && diff <= StyleDifferenceRepaintLayer)

I think this will lead to more maintainable code, but it comes at a cost.

BUG=

Review URL: https://chromiumcodereview.appspot.com/16268018

git-svn-id: svn://svn.chromium.org/blink/trunk@152046 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Remove empty directory

git-svn-id: svn://svn.chromium.org/blink/trunk@152047 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Make WebViewImpl's background color consistent with transparency

WebLayerTreeView's background color is used for filling in missing
content with some color.  If WebViewImpl is transparent, then its
background color should be consistent with that.

R=jamesr@chromium.org
BUG=247672

Review URL: https://chromiumcodereview.appspot.com/15716017

git-svn-id: svn://svn.chromium.org/blink/trunk@152048 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Select two-word misspellings with Mac editing behavior

This CL moves select-on-context-click logic to event handler to enable Mac
editing behavior to select two-word misspellings on context click.

TEST=LayoutTests/editing/spelling/spelling-should-select-multiple-words.html
TEST=LayoutTests/editing/spelling/spelling-should-select-single-word.html
BUG=233232

Review URL: https://chromiumcodereview.appspot.com/16321007

git-svn-id: svn://svn.chromium.org/blink/trunk@152049 bbb929c8-8fbe-4397-9dbb-9b2b20218538
(Re-land) Get rid of extraneous accessibility tree traversal code.

We never used AccessibilityRenderObject::previousSibling, and
I've been scared for a long time someone would accidentally
use it and we'd discover it's full of bugs, since it had no
test coverage. (Several bugs have been caught in nextSibling over
the years.) Time for it to die.

We also don't need AccessibilityObject::lastChild, though
the implementation was trivial.

The public interface needs even less - we can get rid of
firstChild, lastChild, nextSibling, and previousSibling,
because childAt is the only one called.

BUG=247082
R=eseidel@chromium.org, jamesr@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152005

Review URL: https://chromiumcodereview.appspot.com/16361013

git-svn-id: svn://svn.chromium.org/blink/trunk@152050 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Prepopulate the memoryCache with data:uri images.

This patch prepopulates the memoryCache for data:uri
images, fixing a long-standing bug where data uri
subresources did not load for SVG images (network
loads are still disabled).

The two large changes are the following new methods:
1) resourceFromDataURIRequest has been added which
returns a resource from a data uri request. This
function was placed on CachedResource because it
needs to use the createResource helper function. I
hope this function can be re-used in a followup
patch to reduce memory in data uri handling.

2) preCacheDataURIImage has been added which simply
prefills the memory cache with a data uri image.
Care is taken to evict any resources that have the
incorrect type.

Note: the following Chromium-side change is required:
https://codereview.chromium.org/16096016/

BUG=224317
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/16433002

git-svn-id: svn://svn.chromium.org/blink/trunk@152058 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Re-land: remove virtual from functions that are never overridden.

Original patch (https://codereview.chromium.org/16465002/) had a bug
and was reverted.

This time, adds OVERRIDE to all virtual functions overridden in
AccessibilityNodeObject and AccessibilityRenderObject to help avoid
such errors.

BUG=247082

Review URL: https://chromiumcodereview.appspot.com/15984011

git-svn-id: svn://svn.chromium.org/blink/trunk@152060 bbb929c8-8fbe-4397-9dbb-9b2b20218538