CLOUDSTACK-4426
[VMware] [upgrade] system VM not coming up after upgrade from 3.0.4 to 4.2
CLOUDSTACK-4392: API volumeresponse - return primary storage information to ROOT and resource domain admin only.
CLOUDSTACK-4429. DOC. Fix broken link in header of API Reference TOC page. The link pointed to the Developer's Guide on the old doc site. Changed to point to the new doc site. Does not point to a specific doc version, so this text can be re-used without change for future software releases.
CLOUDSTACK-4428: "kvm.snapshot.enabled" flag shouldn't affect detached volumes, or volumes attached to the vm in Stopped/Destroyed state
CLOUDSTACK-4428: UI > volume > when hypervisor is KVM and kvm.snapshot.enabled configuration is false, still show Take Snapshot option if VM State is Stopped.
CLOUDSTACK-867. DOC. Fix how-to steps for updating an existing VM to have dynamic scaling capability.
CLOUDSTACK-2729: another try to solve libvirt storage pool missing issue: if the storage pool is missing, then recreate it
CLOUDSTACK-4433:[VMware]Registration of template using the downloaded
template URL is failing.
CLOUDSTACK-3927, CLOUDSTACK-3928: Fix NS scripts to add/remove NS device in setupClass/tearDown

Signed-off-by: Prasanna Santhanam <tsp@apache.org>
CLOUDSTACK-2131: [Performance][Enhancement] Avoid checking for providers that are not enabled while creating network.
For some scenarios like prepare nic, all network service providers are checked which is not efficient and also introduces unnecessary dependencies.
The check to use only the required providers is already there for implement, shutdown operation on network. Put the same check for all missing cases.
CLOUDSTACK-3441: [Load Test] High delays between VM being allocated to Pod and network implementation causing delays in VM deployment
The locking code in implement/shutdown network code was not efficient. Even in order to check the current state of the network lock was getting acquired which is not required. This resulted in delays in deploy VM as can be seen from attached logs where the code waited on the lock just to check if network is implemented.
As part of the fix moved out code that is checking if the network is already implemented or shutdowned outside the lock.
CLOUDSTACK-4442: Include a test for creating networks with sourcenat only

The test attempts to create a network with offering serving only
dhcp,dns and sourcenat. However the source NAT functionality itself
isn't tested as reported in the bug. So the test will pass.

TODO: come up with a way to test source nat without enabling additional
services for pf/staticnat

Signed-off-by: Prasanna Santhanam <tsp@apache.org>
CLOUDSTACK-4437: Fix iso usage event count to match the number of image stores

Signed-off-by: Prasanna Santhanam <tsp@apache.org>
CLOUDSTACK-4442: Source NAT not applied when network starts up

ensure on network implement/restart/shutdown an ip assoc is sent so that
source nat ip is associated with source nat service provider.
CLOUDSTACK-4115 : Encrypt password in cluster_details table. This fix is to handle upgrades from versions earlier than 3.0.5 and 4.0. Upgrade was not handled when the cluster_details password encryption was introduced.
CLOUDSTACK-4453: fetch host credentials from marvin config

Tests would fetch the credentials for the host to hop into router to
check for essential services. Each test would require to put in the host
information into the test data. Instead fetch the credential information
from the marvin configuration file.

Signed-off-by: Prasanna Santhanam <tsp@apache.org>
CLOUDSTACK-4442: Source NAT not applied when network starts up

fixing the buid break introduced with prev commit for this bug
CLOUDSTACK-4661: fix vpcid field in response of creating vpn gateway
CLOUDSTACK-4460: VPC list UI: Truncate long values to prevent overflow.
CLOUDSTACK-4431: Fix icon for release dedicated host