looks good to me (in the future we do want to support the more obvious hash syntax though, but today we don't in this plugin)