Yes, we should use BaseTool.SUCCESS/FAILURE everywhere.
As I had added the "// success" comment for the 3rd time, I decided we needed a constant for this.