added docs and found a missing test