add idents to docstring
add tests