Yeah and you still need to correct how functions are treating the return value... This is a completely different data type.



On Feb 5, 2013, at 9:56 AM, "dmaloney-r7" <notifications@github.com<mailto:notifications@github.com>> wrote:


In lib/rex/proto/http/client.rb:

> @@ -180,8 +201,8 @@ def request_raw(opts={})
>               req << set_extra_headers(c_head)
>               req << set_raw_headers(c_rawh)
>               req << set_body(c_body)
> -
> -             req
> +
> +             {:string => req , :opts => opts}


i agree that it's not ideal. However, returning a string is stupid, and it is literally impossible to do the auth without keeping those opts in the chain. Also nothing in the entire codebase calls request_cgi or request_raw in a way that does anything but send the return to send_recv.

—
Reply to this email directly or view it on GitHub<https://github.com/rapid7/metasploit-framework/pull/1444/files#r2894689>.


This electronic message contains information which may be confidential or privileged. The information is intended for the use of the individual or entity named above. If you are not the intended recipient, be aware that any disclosure, copying, distribution or use of the contents of this information is prohibited. If you have received this electronic transmission in error, please notify us by e-mail at (postmaster@rapid7.com) immediately.