On Nov 21, 2013, at 11:01 PM, MohtaMayank <notifications@github.com> wrote:

> In src/main/java/edu/cmu/graphchi/toolkits/collaborative_filtering/algorithms/LibFM_MCMC.java:
> 
> > +			Iterator<VectorEntry> it2 = row.iterator();
> > +			while(it2.hasNext()) {
> > +				VectorEntry xj = it2.next();
> > +				double[] vj = this.params.v[xj.getIndex()];
> > +				double dotProd = 0;
> > +				for(int f = 0; f < this.params.D; f++) {
> > +					dotProd += vi[f]*vj[f];
> > +				}
> > +				
> > +				// <vi, vj>*xi*xj +
> > +				estVal += dotProd*xi.getValue()*xj.getValue();
> > +			}
> > +		}
> > +		
> > +		estVal = Math.min(estVal, this.setup.minval);
> > +		estVal = Math.max(estVal, this.setup.maxval);
> Agreed. One thing which I have not done badly in this project is testing. No unit tests and some limited testing over small datasets.
> The entire LibFM_MCMC code is commented out currently. Will either rectify the complete code or delete this file.
> 
> —
> 
Boolean bug in your comment as well :) (extra "not").