Well done Dave! I've merged the master changes with my forked branch and
its all working well with the orphanRemoval.I've removed the not required
delete concept service and updated my forked branch. :)

p/s : in my opinion, annotations looks so much clearer the relationship and
structure of the entities compared to the hbm.xml !




On Sat, Jan 26, 2013 at 11:31 PM, David Sanders <notifications@github.com>wrote:

> In
> api/src/main/java/org/openmrs/module/cpm/api/ProposedConceptService.java:
>
> > @@ -93,8 +90,20 @@
> >  	@Authorized(ConceptProposalConsts.MODULE_PRIVILEGE)
> >  	@Transactional
> >  	void deleteProposedConceptPackage(ProposedConceptPackage conceptPackage) throws APIException;
> > -	
> > -	//	Moving on to all of the services for the server side of the Concept Proposal Module
> > +
> > +    /**
> > +     * Deletes a ProposedConcept
> > +     *
> > +     * @param The ProposedConcept to be removed from persistent storage
> > +     * @throws APIException
> > +     * @since 1.0
> > +     */
> > +    @Authorized(ConceptProposalConsts.MODULE_PRIVILEGE)
> > +    @Transactional
> > +    void deleteProposedConcept(ProposedConcept proposedConcept) throws APIException;
>
> Ok I got it working... finally... :D
> After a couple of hours trying to wrangle with Hibernate and our inherited
> entities, I got your code working without the need to explicitly delete
> them :)
> So you'll need to update your fork with the commits I've added to use
> annotations and it should work!
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/johnsyweb/openmrs-cpm/pull/3/files#r2784605>.
>
>