I didn't know those would suffice for pylint. I'm wary of the
non-underscored version as implying "public" accessibility.


On Fri, Aug 16, 2013 at 9:36 AM, Calen Pennington
<notifications@github.com>wrote:

> In common/lib/xmodule/xmodule/modulestore/django.py:
>
> > @@ -46,3 +47,18 @@ def modulestore(name='default'):
> >  #     # Initialize the modulestores immediately
> >  #     for store_name in settings.MODULESTORE:
> >  #         modulestore(store_name)
> > +
> > +_loc_singleton = None
> > +def loc_mapper():
> > +    """
> > +    Get the loc mapper which bidirectionally maps Locations to Locators. Used like modulestore() as
> > +    a singleton accessor.
> > +    """
> > +    # pylint: disable=W0603
> > +    global _loc_singleton
>
> Rather than ignoring the pylint errors, why not just make this
> _LOC_SINGLETON (or, even better, LOCATION_MAPPER)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/edx/edx-platform/pull/661/files#r5813741>
> .
>