Fix comment typos

Signed-off-by: David Zafman <david.zafman@inktank.com>
librbd: simplify diff_iterate calls to list_snaps

We don't need the size.  Use the simpler API call.

Signed-off-by: Sage Weil <sage@inktank.com>
mon: make 'osd crush rm|unlink ...' idempotent

Return 0 if the item is not there, not -ENOENT.

Fixes: #4624
Signed-off-by: Sage Weil <sage@inktank.com>
librados: fix list_snaps() tests

The ioctx must be set to SNAP_DIR, and the head does not include any
clones.

Bug #4623

Signed-off-by: David Zafman <david.zafman@inktank.com>
osd: fail with EINVAL if bad snapid set on list_snaps

Signed-off-by: David Zafman <david.zafman@inktank.com>
librados: set SNAP_DIR on listsnaps command

Signed-off-by: David Zafman <david.zafman@inktank.com>
librados: test for EINVAL on bad list_snaps() ioctx snapid

Signed-off-by: Sage Weil <sage@inktank.com>
librados: Fixes to list_snaps test changes

Add back assert for overlap
Fix snap size and remove unnecessary comments
Fix failing test cases

Signed-off-by: David Zafman <david.zafman@inktank.com>
mon: limit warnings about low mon disk space

Only warn once per percentage point per epoch.

Signed-off-by: Sage Weil <sage@inktank.com>
Merge remote-tracking branch 'gh/wip-4623'
Merge pull request #193 from ceph/wip-mon-crush

mon: make 'osd crush rm|unlink ...' idempotent

Reviewed-by: Dan Mick dan.mick@inktank.com
Merge pull request #192 from ceph/wip-mon-disk-warn

mon: limit warnings about low mon disk space

Reviewed-by: Joao Eduardo Luis <joao.luis@inktank.com>
Makefile.am: fix build of ceph_test_cors

Fix build of ceph_test_cors: use $(CRYPTO_LIBS) instead of -lcryptopp.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Merge pull request #195 from dalgaaf/wip-da-fix-make

Makefile.am: fix build of ceph_test_cors

Reviewed-by: Sage Weil <sage@inktank.com>
Merge pull request #194 from ceph/wip-rbd-diff

Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
mds: do not go through handle_mds_failure for oneself

A standby MDS can attempt the handle_mds_failure paths for itself, if
it sees the transition from up to down. This leads it to insert itself
into the resolve_gather set, which is bad. So check if the failed MDS
is the same as whoami, and abort if so. This fixes #4637.

Signed-off-by: Greg Farnum <greg@inktank.com>
Reviewed-by: Yan, Zheng <zheng.z.yan@intel.com>
mon: make 'osd crush unlink ..' idempotent

Signed-off-by: Sage Weil <sage@inktank.com>
mds: verify mds tell 'dumpcache <filename>' target does not exist

Open target with O_CREAT|O_EXCL to ensure we don't overwrite some other
important file (like, say, /etc/passwd).  This is irritating because there
is not c++ ofstream equivalent for O_EXCL; kludge around it using
ostringstream instead.

Fixes: #3266
Signed-off-by: Sage Weil <sage@inktank.com>
Merge pull request #197 from ceph/wip-3266

mds: verify mds tell 'dumpcache <filename>' target does not exist

Reviewed-by: Greg Farnum <greg@inktank.com>
mon: fix crush unit tests for idempotency

Signed-off-by: Sage Weil <sage@inktank.com>