Whoa whoa hrrrm. Maybe I should just rename it to "should_handle" or
something like that, and make that return type 1/0... actually I think I
will.


On Fri, Apr 19, 2013 at 1:09 PM, Mark Smith <notifications@github.com>wrote:

> In cgi-bin/DW/EmailPost.pm:
>
> > +    }
> > +=cut
> > +
> > +=head2 C<< $class->get_handler( $mime_object ) >>
> > +
> > +Returns an instance of DW::EmailPost::* that can handle the given email
> > +
> > +=cut
> > +sub get_handler {
> > +    my ( $class, $mime_object ) = @_;
> > +
> > +    my $handler;
> > +    my $destination;
> > +    if ( $destination = DW::EmailPost::Entry->find_destination( $mime_object ) ) {
> > +        $handler = DW::EmailPost::Entry->new( $mime_object );
> > +    } elsif ( $destination = DW::EmailPost::Reply->find_destination( $mime_object ) ) {
>
> Wait... you never use $destination? What's going on here?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dreamwidth/dw-free/pull/346/files#r3867918>
> .
>