I don't think we made this change. We only made the changes details in
http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Spring_2013/OSS_E605A.
Did we start with a different code base possibly and it was out of
sync
in lots of other ways before we began?


On Tue, Apr 23, 2013 at 7:56 PM, Andrew Kofink <notifications@github.com>wrote:

> In app/models/participant.rb:
>
> > @@ -175,7 +175,7 @@ def get_scores(questions)
> >      scores[:participant] = self
> >      self.assignment.questionnaires.each do |questionnaire|
> >        scores[questionnaire.symbol] = Hash.new
> > -      scores[questionnaire.symbol][:assessments] = questionnaire.get_assessments_for(self)
>
> Everywhere you had get_assessments_for using polymorphism was far better
> than calling each subclass of Questionnaire's differently named methods,
> which your refactoring added. In the project description, I think what
> @efg <https://github.com/efg> meant was that get_assessments_for() was
> simply a bad name, not that you should get rid of the polymorphism (which
> is a great thing).
>
> The solution is easy: just roll back these changes and rename
> get_assessments_for to a better method name. Perhaps @efg<https://github.com/efg>can suggest a better name.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/expertiza/expertiza/pull/260/files#r3928589>
> .
>