Bumped vcap_common
Do not track Gemfile.lock
Relax em-http-request and EM

Also locks down nats as the latest version at the time (0.4.28) locks
down EM to 0.12.10 which we want to bump.
Bump vcap_common and em-http-request

This commit also fixes create_http_request and cc_http_request along the
way, no longer assuming http.error is a string.
require nats helper when necessary

  We depended on the pollution before...
Slight refactoring of the CatalogMangerV2
Sending extra from catalog manager to CCNG
Whitespaces
Privatize methods
Small refactor, move things around
Delete redundant function_test spec

These files are identical to the files with the same name in unit_spec

[#47656417]
Remove tests duplicated in functional_test

[#47656417]
remove link to Jira
Pass through plan extra field. No tests. For the win.
Update plans when their extra field changes
Add debug logging to plan advertisement
Get more info from pool_run log

We're getting a massive number of warnings with no useful stack trace,
so try to get a little more useful information out of it.
CatalogManager advertises unique_id

* This affects Services and ServicePlans

[#47382155]
allow more than one dash in the sythesized label
Pass through some extra information in the service offering