Ahhhh I see.  After using phabricator I'm terrible at reading Github diffs now.  Yes this all looks correct.