finish feature/set_get_attr