FlipPage will never block. The WaitForBuffer above can block if you set a
large timeout value. You now set 0 so it won't block.


On Sat, Jun 8, 2013 at 5:27 PM, popcornmix <notifications@github.com> wrote:

> In xbmc/cores/omxplayer/OMXPlayerVideo.cpp:
>
> >    if (buffer < 0)
> >      return;
> >
> > -  double pts_media = m_av_clock->OMXMediaTime(false);
> > -  ProcessOverlays(pts_media);
> > -
> > -  g_renderManager.FlipPage(CThread::m_bStop, m_iSleepEndTime / DVD_TIME_BASE, -1, FS_NONE);
> > -
> > -  m_iSleepEndTime = DVD_NOPTS_VALUE;
> > -
> > -  //m_av_clock->WaitAbsoluteClock((iCurrentClock + iSleepTime));
> > +  ProcessOverlays(media_pts);
> > +  g_renderManager.FlipPage(CThread::m_bStop);
>
> But if the timestamp has any effect, then it will block this thread for
> that duration won't it?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/xbmc/xbmc/pull/2849/files#r4601812>
> .
>