Fixed with new patch.  For some reason these comments don't show up on the PR. 

-Evan
To be free is not merely to cast off one's chains, but to live in a way that respects & enhances the freedom of others. (#NelsonMandela)

On Sep 9, 2013, at 1:41 PM, Jey Kottalam <notifications@github.com> wrote:

> In core/src/main/scala/org/apache/spark/util/Utils.scala:
> 
> > @@ -457,12 +457,18 @@ private[spark] object Utils extends Logging {
> >    def newDaemonFixedThreadPool(nThreads: Int): ThreadPoolExecutor =
> >      Executors.newFixedThreadPool(nThreads, daemonThreadFactory).asInstanceOf[ThreadPoolExecutor]
> >  
> > +  private def listFilesSafely(file: File): Seq[File] = {
> > +    val files = file.listFiles()
> > +    if (files == null) throw new IOException("Failed to list files for dir: " + file)
> I believe the usual Spark style convention is to use the extra braces and put it on a separate line, because that is more future-proof (e.g. if additional code is added within the body of the if).
> 
> —
> Reply to this email directly or view it on GitHub.
>