Adjusted!
By the way, you don't have a brother named Kevin Nugent do you?  A fellow I met and worked with a few years back who was a project manager here in Vancouver; I think his roots were in Nova Scotia too?!
ciao,
d.

----------------------------------------
From: "Jason Nugent" <notifications@github.com>
Sent: Tuesday, August 13, 2013 10:07 AM
To: "pkp/ojs" <ojs@noreply.github.com>
Cc: "Damion Dooley" <damion@learningpoint.ca>
Subject: Re: [ojs] XML plugin -- corrections made (#92)

In plugins/xmlMarkup/MarkupPlugin.inc.php: 

> +	* > +	* @param $hookName string > +	* @param $params array [$galleyId] > +	* > +	* @see register() > +	**/ > +	function _deleteGalley($hookName, $params) { > +		$galleyId=$params[0]; > +		$galleyDao =& DAORegistry::getDAO('ArticleGalleyDAO'); > +		$galley =& $galleyDao->getGalley($galleyId); > +		$data = $galley->_data; > +		$label = $data['label']; // HTML / PDF / XML > +		$articleId = $data['submissionId']; > +		$remoteURL = $data['remoteURL']; > +		//if trailing url is clearly made by this Plugin ... > +		if (preg_match("#plugin/markup/$articleId/[0-9]+/document(.html|-new.pdf|.xml)#", $remoteURL, $matches)) {  

I suggest escaping the periods in the regex, especially if you want to guarantee a file extension.  Possibly, also anchoring the pattern with $.  

-
Reply to this email directly or view it on GitHub.