[chromium] Dynamically removing preserve-3d from a layer has no effect
https://bugs.webkit.org/show_bug.cgi?id=95732

Patch by Sami Kyostila <skyostil@google.com> on 2012-09-07
Reviewed by James Robinson.

Move preserve-3d-toggle.html to the common compositing tests directory because
it isn't Chromium-specific.

* compositing/preserve-3d-toggle-expected.png: Renamed from LayoutTests/platform/chromium/compositing/preserve-3d-toggle-expected.png.
* compositing/preserve-3d-toggle-expected.txt: Renamed from LayoutTests/platform/chromium/compositing/preserve-3d-toggle-expected.txt.
* compositing/preserve-3d-toggle.html: Renamed from LayoutTests/platform/chromium/compositing/preserve-3d-toggle.html.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127908 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Use same default minimum logical font size in DRT and WTR
https://bugs.webkit.org/show_bug.cgi?id=96116

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-07
Reviewed by Martin Robinson.

Source/WebKit/efl:

Add DRT helper function to set the minimum logical
font size setting.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setMinimumLogicalFontSize):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit2:

Add private bundle C API to set the minimum logicial font
size setting. This is needed by WebKitTestRunner.

* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetMinimumLogicalFontSize):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setMinimumLogicalFontSize):
(WebKit):
* WebProcess/InjectedBundle/InjectedBundle.h:
(InjectedBundle):

Tools:

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues): Set minimum
logical font size to 9 to match the value used in WTR.
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting): Explicitly set the minimum
logical font size to 9 (default value in WK2)

LayoutTests:

Provide new baseline for several tests now that the minimum
logical font size setting is set to 9 in EFL's DRT.

Unskip several tests in EFL WK2 now that EFL's DRT uses
the same minimum logical font size and now that the tests
have been rebaselined.

* platform/efl-wk2/TestExpectations:
* platform/efl/fast/css/bidi-override-in-anonymous-block-expected.png:
* platform/efl/fast/css/bidi-override-in-anonymous-block-expected.txt: Added.
* platform/efl/fast/ruby/nested-ruby-expected.png:
* platform/efl/fast/ruby/nested-ruby-expected.txt:
* platform/efl/fast/ruby/ruby-beforeafter-expected.png:
* platform/efl/fast/ruby/ruby-beforeafter-expected.txt:
* platform/efl/fast/ruby/ruby-empty-rt-expected.png:
* platform/efl/fast/ruby/ruby-empty-rt-expected.txt:
* platform/efl/fast/ruby/ruby-length-expected.png:
* platform/efl/fast/ruby/ruby-length-expected.txt:
* platform/efl/fast/ruby/ruby-run-break-expected.png:
* platform/efl/fast/ruby/ruby-run-break-expected.txt:
* platform/efl/fast/ruby/ruby-runs-expected.png:
* platform/efl/fast/ruby/ruby-runs-expected.txt:
* platform/efl/fast/ruby/ruby-runs-spans-expected.png:
* platform/efl/fast/ruby/ruby-runs-spans-expected.txt:
* platform/efl/fast/ruby/ruby-simple-expected.png:
* platform/efl/fast/ruby/ruby-simple-expected.txt:
* platform/efl/fast/ruby/ruby-simple-rp-expected.png:
* platform/efl/fast/ruby/ruby-simple-rp-expected.txt:
* platform/efl/fast/ruby/ruby-trailing-expected.png:
* platform/efl/fast/ruby/ruby-trailing-expected.txt:
* platform/efl/fast/ruby/rubyDOM-insert-rt-expected.png:
* platform/efl/fast/ruby/rubyDOM-insert-rt-expected.txt:
* platform/efl/fast/ruby/rubyDOM-insert-text1-expected.png:
* platform/efl/fast/ruby/rubyDOM-insert-text1-expected.txt:
* platform/efl/fast/ruby/rubyDOM-insert-text2-expected.png:
* platform/efl/fast/ruby/rubyDOM-insert-text2-expected.txt:
* platform/efl/fast/ruby/rubyDOM-insert-text3-expected.png:
* platform/efl/fast/ruby/rubyDOM-insert-text3-expected.txt:
* platform/efl/fast/ruby/rubyDOM-remove-rt1-expected.png:
* platform/efl/fast/ruby/rubyDOM-remove-rt1-expected.txt:
* platform/efl/fast/ruby/rubyDOM-remove-rt2-expected.png:
* platform/efl/fast/ruby/rubyDOM-remove-rt2-expected.txt:
* platform/efl/fast/ruby/rubyDOM-remove-text1-expected.png:
* platform/efl/fast/ruby/rubyDOM-remove-text1-expected.txt:
* platform/efl/fast/ruby/rubyDOM-remove-text2-expected.png:
* platform/efl/fast/ruby/rubyDOM-remove-text2-expected.txt:
* platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png:
* platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127909 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Regression: check-webkit-style no longer checks TestExpectations for syntax errors
https://bugs.webkit.org/show_bug.cgi?id=96136

Reviewed by Ojan Vafai.

When we renamed the file to TestExpectations, it was no longer considered a text file so
it was no longer being checked. Since then, test_expectations_overrides() has been removed
from the port object, so I've removed that from the check. I'm not sure what it was
supposed to do.

* Scripts/webkitpy/style/checker.py:
(CheckerDispatcher._file_type): Mark TestExpectations as a text file.
* Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker.check_test_expectations): Remove overrides param.
(TestExpectationsChecker.check): Remove overrides param.
* Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase.assert_lines_lint): Remove overrides param.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[CSS Shaders] [BlackBerry] Refactor CustomFilterMesh and CustomFilter*Program
https://bugs.webkit.org/show_bug.cgi?id=94725

Reviewed by Rob Buis.

Separate the MeshGenerator from the CustomFilterMesh into
CustomFilterMeshGenerator.h/cpp. This allows the BlackBerry port to
reuse the mesh generator in its accelerated compositing implementation.

Also add support for creating a "PlatformCompiledProgram" from a
CustomFilterValidatedProgram, so the BlackBerry port can reuse the
shader validation code in its accelerated compositing implementation.

It turns out the GraphicsContext3D is not needed for ANGLE to function,
so this patch removes an ASSERT that required a context before
validating the shaders using ANGLE. This allows the BlackBerry port to
reuse the validation code without triggering the assert. In the future,
the validation code could be moved to a separate class to make it more
obvious that it isn't really related to GraphicsContext3D.

In general, this refactoring can be useful for any port that uses
OpenGL to implement accelerated compositing.

Inspired by an original patch by Joshua Netterfield.

No new tests, because this patch implements no new functionality.

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/filters/CustomFilterGlobalContext.cpp:
(WebCore::CustomFilterGlobalContext::getValidatedProgram):
* platform/graphics/filters/CustomFilterMesh.cpp:
(WebCore::CustomFilterMesh::CustomFilterMesh):
* platform/graphics/filters/CustomFilterMeshGenerator.cpp: Added.
(WebCore):
(WebCore::CustomFilterMeshGenerator::CustomFilterMeshGenerator):
(WebCore::CustomFilterMeshGenerator::addAttachedMeshIndex):
(WebCore::CustomFilterMeshGenerator::generateAttachedMesh):
(WebCore::CustomFilterMeshGenerator::addDetachedMeshVertexAndIndex):
(WebCore::CustomFilterMeshGenerator::generateDetachedMesh):
(WebCore::CustomFilterMeshGenerator::addPositionAttribute):
(WebCore::CustomFilterMeshGenerator::addTexCoordAttribute):
(WebCore::CustomFilterMeshGenerator::addMeshCoordAttribute):
(WebCore::CustomFilterMeshGenerator::addTriangleCoordAttribute):
(WebCore::CustomFilterMeshGenerator::addAttachedMeshVertexAttributes):
(WebCore::CustomFilterMeshGenerator::addDetachedMeshVertexAttributes):
(WebCore::CustomFilterMeshGenerator::dumpBuffers):
* platform/graphics/filters/CustomFilterMeshGenerator.h: Added.
(WebCore):
(CustomFilterMeshGenerator):
(WebCore::CustomFilterMeshGenerator::vertices):
(WebCore::CustomFilterMeshGenerator::indices):
(WebCore::CustomFilterMeshGenerator::points):
(WebCore::CustomFilterMeshGenerator::pointsCount):
(WebCore::CustomFilterMeshGenerator::tiles):
(WebCore::CustomFilterMeshGenerator::tilesCount):
(WebCore::CustomFilterMeshGenerator::indicesCount):
(WebCore::CustomFilterMeshGenerator::floatsPerVertex):
(WebCore::CustomFilterMeshGenerator::verticesCount):
(WebCore::CustomFilterMeshGenerator::addTile):
* platform/graphics/filters/CustomFilterValidatedProgram.cpp:
(WebCore::CustomFilterValidatedProgram::CustomFilterValidatedProgram):
(WebCore::CustomFilterValidatedProgram::compiledProgram):
(WebCore::CustomFilterValidatedProgram::~CustomFilterValidatedProgram):
(WebCore):
(WebCore::CustomFilterValidatedProgram::platformCompiledProgram):
(WebCore::CustomFilterValidatedProgram::platformDestroy):
* platform/graphics/filters/CustomFilterValidatedProgram.h:
(WebCore):
(CustomFilterValidatedProgram):
* platform/graphics/filters/blackberry/CustomFilterValidatedProgramBlackBerry.cpp: Added.
(WebCore):
(WebCore::CustomFilterValidatedProgram::platformCompiledProgram):
(WebCore::CustomFilterValidatedProgram::platformDestroy):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, fix incorrect comment character(s) in Skipped list.

* platform/mac/Skipped:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] Remove bad assert in CCRenderPass::Id
https://bugs.webkit.org/show_bug.cgi?id=96138

Reviewed by James Robinson.

The assert prevents HashMap from creating "deleted" and "empty" ids. We
assert that RenderPasses have correct ids already, and don't need to
assert inside the Id structure itself.

* platform/graphics/chromium/cc/CCRenderPass.h:
(WebCore::CCRenderPass::Id::Id):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127913 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Make RenderBox::computeLogicalWidthInRegion const
https://bugs.webkit.org/show_bug.cgi?id=96129

Reviewed by Ojan Vafai.

Making computeLogicalWidthInRegion const allows us to get rid of the gross hack in
RenderBox::renderBoxRegionInfo.

No new tests, this is covered by existing layout tests.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::constrainLogicalWidthInRegionByMinMax): Make const.
(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats): Make const.
(WebCore::RenderBox::computeLogicalWidth): Use a LogicalExtentComputedValues when calling computeLogicalWidthInRegion.
(WebCore::RenderBox::computeLogicalWidthInRegion): Make const. Fill in a LogicalExtentComputedValues struct instead.
(WebCore::RenderBox::computeLogicalWidthInRegionUsing): Make const.
(WebCore::RenderBox::renderBoxRegionInfo): Remove hack and get region width values in a LogicalExtentComputedValues struct.
* rendering/RenderBox.h:
(RenderBox):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127914 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix RenderBox::availableHeight to subtract scrollbars in the right places
https://bugs.webkit.org/show_bug.cgi?id=96031

Reviewed by Tony Chang.

Source/WebCore:

This matches Firefox 15 and IE9 rendering for the two new tests.

Tests: fast/block/positioning/percent-top-left-on-relative-position.html
       fast/css/nested-percent-height-on-replaced.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePercentageLogicalHeight):
Subtract scrollbars when recurring on percentage heights.
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
This is the wrong place to subtract scrollbars. availableLogicalHeight
should return a value that doesn't include scrollbars.
(WebCore::RenderBox::availableLogicalHeightUsing):
Subtract scrollbars from specified heights. Also, consolidate the code to
use computeContentLogicalHeightUsing. This makes percentage heights use
the right containingBlock in quirks mode and makes viewport percentage heights work.

LayoutTests:

* fast/block/positioning/percent-top-left-on-relative-position-expected.html: Added.
* fast/block/positioning/percent-top-left-on-relative-position.html: Added.
* fast/css/nested-percent-height-on-replaced-expected.txt: Added.
* fast/css/nested-percent-height-on-replaced.html: Added.
* platform/chromium-linux/fast/css/percent-top-value-with-relative-position-expected.png:
* platform/chromium-win/fast/css/percent-top-value-with-relative-position-expected.txt:
This is now correctly centering the 50%. It moved up 8px because that is half of the body's margin.
This matches other Firefox 15 and IE9.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127915 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] Unreviewed gardening.  Remove platform/chromium-linux/compositing/gestures
test skipping. All compositing tests seem to have the same failure.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127916 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix linter errors. The deleted lines are all tests that are passing
or that no longer exist at that path.

* platform/efl/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127917 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, rolling out r127911.
http://trac.webkit.org/changeset/127911
https://bugs.webkit.org/show_bug.cgi?id=96146

Patch breaks build with clang (Requested by rbuis on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-07

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/filters/CustomFilterGlobalContext.cpp:
(WebCore::CustomFilterGlobalContext::getValidatedProgram):
* platform/graphics/filters/CustomFilterMesh.cpp:
(WebCore):
(MeshGenerator):
(WebCore::MeshGenerator::MeshGenerator):
(WebCore::MeshGenerator::vertices):
(WebCore::MeshGenerator::indices):
(WebCore::MeshGenerator::points):
(WebCore::MeshGenerator::pointsCount):
(WebCore::MeshGenerator::tiles):
(WebCore::MeshGenerator::tilesCount):
(WebCore::MeshGenerator::indicesCount):
(WebCore::MeshGenerator::floatsPerVertex):
(WebCore::MeshGenerator::verticesCount):
(WebCore::MeshGenerator::addTile):
(WebCore::MeshGenerator::addAttachedMeshIndex):
(WebCore::MeshGenerator::generateAttachedMesh):
(WebCore::MeshGenerator::addDetachedMeshVertexAndIndex):
(WebCore::MeshGenerator::generateDetachedMesh):
(WebCore::MeshGenerator::addPositionAttribute):
(WebCore::MeshGenerator::addTexCoordAttribute):
(WebCore::MeshGenerator::addMeshCoordAttribute):
(WebCore::MeshGenerator::addTriangleCoordAttribute):
(WebCore::MeshGenerator::addAttachedMeshVertexAttributes):
(WebCore::MeshGenerator::addDetachedMeshVertexAttributes):
(WebCore::MeshGenerator::dumpBuffers):
(WebCore::CustomFilterMesh::CustomFilterMesh):
* platform/graphics/filters/CustomFilterMeshGenerator.cpp: Removed.
* platform/graphics/filters/CustomFilterMeshGenerator.h: Removed.
* platform/graphics/filters/CustomFilterValidatedProgram.cpp:
(WebCore::CustomFilterValidatedProgram::CustomFilterValidatedProgram):
(WebCore::CustomFilterValidatedProgram::compiledProgram):
(WebCore::CustomFilterValidatedProgram::~CustomFilterValidatedProgram):
* platform/graphics/filters/CustomFilterValidatedProgram.h:
(CustomFilterValidatedProgram):
* platform/graphics/filters/blackberry/CustomFilterValidatedProgramBlackBerry.cpp: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127918 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Bulk migrate past Timelapse work to new, official Git mirror repository. Old commit history for Timelapse is available at https://github.com/burg/timelapse/tree/deprecated-timelapse/ (more recent) and https://bitbucket.org/burg/timelapse/ (older).