'perl -w' safety in mkfiles.pl.


git-svn-id: svn://svn.tartarus.org/sgt/putty@8958 cda61777-01e9-0310-a592-d414129be87e
Move '-w' in the #! line into 'use warnings;' in the Perl code, to
simplify the #! line.


git-svn-id: svn://svn.tartarus.org/sgt/putty@8967 cda61777-01e9-0310-a592-d414129be87e
Set WM_TRANSIENT_FOR appropriately on the "about" box so that fvwm doesn't
insist on finding a bit of spare screen to put it in.  Still pondering whether
it's sensible to do this with the "change settings" box as well.


git-svn-id: svn://svn.tartarus.org/sgt/putty@8970 cda61777-01e9-0310-a592-d414129be87e
Patch from Alan Ning (somewhat polished by me): introduce a flag
called 'pending_close'. This deals with the situation in which we're
forwarding a port, have received and locally buffered some data from
the local endpoint but not yet been able to pass it down the SSH
connection due to window limitations, and then the local endpoint
closes its socket. In this situation what we've been doing until now
is to immediately send SSH2_MSG_CHANNEL_CLOSE, causing the data
still in our local buffer to be lost; now we instead set the new
flag, which will remind us to send SSH2_MSG_CHANNEL_CLOSE _after_ we
empty our bufchain.

Should fix at least one manifestation of 'portfwd-close', though I
don't know if it's the cause of all the reports we've ever seen.


git-svn-id: svn://svn.tartarus.org/sgt/putty@8971 cda61777-01e9-0310-a592-d414129be87e
A comment typo fix I've had lying around for a while.


git-svn-id: svn://svn.tartarus.org/sgt/putty@8974 cda61777-01e9-0310-a592-d414129be87e
Cancelling a remote port forwarding that had been refused by the server caused
a double-free. Reported and diagnosed by Sven Schaepe.
Also fix a minor memory leak in ssh_free().


git-svn-id: svn://svn.tartarus.org/sgt/putty@8975 cda61777-01e9-0310-a592-d414129be87e
Mass correction of svn:keywords and svn:eol-style properties.


git-svn-id: svn://svn.tartarus.org/sgt/putty@8980 cda61777-01e9-0310-a592-d414129be87e
When we disconnect because we have no supported authentication
methods left to try, it's nice to have the version of that message
going to the client contain the list of methods sent by the server.
Saves a user having to pull it out of an SSH packet log.


git-svn-id: svn://svn.tartarus.org/sgt/putty@8981 cda61777-01e9-0310-a592-d414129be87e
Cast incoming characters to unsigned char to avoid accidental sign
extension. Since ldisc_send() uses bit 8 as an internal flag, we
shouldn't be setting it except when we really want to.


git-svn-id: svn://svn.tartarus.org/sgt/putty@8989 cda61777-01e9-0310-a592-d414129be87e
Remove redundant check for NULL in sshfwd_close(). The thing we're
testing against NULL has already been dereferenced by the time we
bother to test it, so it's a bit pointless - and in any case, no
null pointer can come to this function from any existing call site.


git-svn-id: svn://svn.tartarus.org/sgt/putty@8990 cda61777-01e9-0310-a592-d414129be87e
Missing close() causing resource leak when reading from /dev/random.


git-svn-id: svn://svn.tartarus.org/sgt/putty@8991 cda61777-01e9-0310-a592-d414129be87e
Create, and use for all loads of system DLLs, a wrapper function
called load_system32_dll() which constructs a full pathname for the
DLL using GetSystemDirectory.

The only DLL load not covered by this change is the one for
gssapi32.dll, because that one's not in the system32 directory.


git-svn-id: svn://svn.tartarus.org/sgt/putty@8993 cda61777-01e9-0310-a592-d414129be87e
Fix obvious braino in the Windows GSSAPI library display names.


git-svn-id: svn://svn.tartarus.org/sgt/putty@8994 cda61777-01e9-0310-a592-d414129be87e
Use the same key for both saving and loading the GSSAPI implementation
preference list. Spotted by Daniel Kessler.


git-svn-id: svn://svn.tartarus.org/sgt/putty@8999 cda61777-01e9-0310-a592-d414129be87e
Cleanups of the GSSAPI support. On Windows, standard GSS libraries
are now loaded from standard locations (system32 for SSPI, the
registry-stored MIT KfW install location for KfW) rather than using
the risky default DLL search path; I've therefore also added an
option to manually specify a GSS DLL we haven't heard of (which
should in principle Just Work provided it supports proper GSS-API as
specified in the RFC). The same option exists on Unix too, because
it seemed like too useful an idea to reserve to Windows. In
addition, GSSAPI is now documented, and also (unfortunately) its GUI
configuration has been moved out into a sub-subpanel on the grounds
that it was too big to fit in Auth.


git-svn-id: svn://svn.tartarus.org/sgt/putty@9003 cda61777-01e9-0310-a592-d414129be87e
Retire the old Mac Classic port directory! It's been unused for
ages, is increasingly irrelevant now that 'Mac' pretty much
universally means something running OS X, is probably bit-rotted
past usefulness already, and certainly will be after the next time
some major reengineering takes place.


git-svn-id: svn://svn.tartarus.org/sgt/putty@9004 cda61777-01e9-0310-a592-d414129be87e
Oops: r9004 should have removed various pieces from the Makefile and
header file setup too.


git-svn-id: svn://svn.tartarus.org/sgt/putty@9005 cda61777-01e9-0310-a592-d414129be87e
Since GSSAPI is now on its own panel, we may as well have a full set of
keyboard shortcuts.


git-svn-id: svn://svn.tartarus.org/sgt/putty@9008 cda61777-01e9-0310-a592-d414129be87e
Add index terms for GSSAPI stuff. Mention GSSAPI in "use system username"
section and other tweaks.


git-svn-id: svn://svn.tartarus.org/sgt/putty@9009 cda61777-01e9-0310-a592-d414129be87e
Bah, r9008 caused an assertion failure on Windows due to a clash with the
shortcuts for the preference list buttons. That'll teach me to only test the
Gtk version.


git-svn-id: svn://svn.tartarus.org/sgt/putty@9010 cda61777-01e9-0310-a592-d414129be87e