change definitions to support input type
rename params to input