On 09/12/2013 05:33 PM, Yang Feng wrote:
>
> In qemu/tests/pci_hotplug.py:
>
> > @@ -313,3 +313,8 @@ def _device_removed():
> >                  error.context(context_msg % (sub_type, "after hotunplug"),
> >                                logging.info)
> >                  utils_test.run_virt_sub_test(test, params, env, sub_type)
> > +
> > +    if params.get("reboot_vm", "no") == "yes":
> > +        vm = env.get_vm(params["main_vm"])
> > +        vm.verify_alive()
> On 09/12/2013 05:14 PM, Xu Tian wrote: In qemu/tests/pci_hotplug.py: > 
> @@ -313,3 +313,8 @@ def _device_removed(): > error.context(context_msg 
> % (sub_type, "after hotunplug"), > logging.info) > 
> utils_test.run_virt_sub_test(test, params, env, sub_type) > + > + if 
> params.get("reboot_vm", "no") == "yes": > + vm = 
> env.get_vm(params["main_vm"]) > + vm.verify_alive() Reboot step should 
> always run after guest wake from suspend, I'm not sure is the guest 
> really works after wake update, so I verified guest alive here to 
> ensure guest works fine before, if guest hang, then we not sure guest 
> hang before or after guest reboot ;
> I think If guest could not works, suspend case should fail. we always 
> have check after suspend.
> … <#>
> — Reply to this email directly or view it on GitHub 
> <https://github.com/autotest/virt-test/pull/842/files#r6316917>.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/autotest/virt-test/pull/842/files#r6317274>.
>
Thanks your comments,  retest found  it works as you said, so remove  
extra step verify guest alive before reboot and add  reboot step 
description in doc-strings;

Xu