Fix possible crash due to unsafe shot iteration.

Fixes regression introduced in 0784d1b9dff.
With a std::list it was okay to create shots while iterating with an
iterator, but not so with a std::vector.
Now using index access, which is safe with push_back() operations.