update but still not working properly