made params work